From c333d0876ce3c5f844ff306f59a2aa670ff80470 Mon Sep 17 00:00:00 2001 From: Aliaksandr Kalenik Date: Sun, 22 Jun 2025 21:39:38 +0200 Subject: [PATCH] LibWeb: Simplify `resolve_definite_track_size()` [GFC] --- .../LibWeb/Layout/GridFormattingContext.cpp | 16 ++++------------ Libraries/LibWeb/Layout/GridFormattingContext.h | 2 +- 2 files changed, 5 insertions(+), 13 deletions(-) diff --git a/Libraries/LibWeb/Layout/GridFormattingContext.cpp b/Libraries/LibWeb/Layout/GridFormattingContext.cpp index 5df83e90ad6..98e4f944f55 100644 --- a/Libraries/LibWeb/Layout/GridFormattingContext.cpp +++ b/Libraries/LibWeb/Layout/GridFormattingContext.cpp @@ -202,20 +202,12 @@ GridFormattingContext::GridFormattingContext(LayoutState& state, LayoutMode layo GridFormattingContext::~GridFormattingContext() = default; -CSSPixels GridFormattingContext::resolve_definite_track_size(CSS::GridSize const& grid_size, AvailableSpace const& available_space) +CSSPixels GridFormattingContext::resolve_definite_track_size(CSS::GridSize const& grid_size, AvailableSpace const& available_space) const { VERIFY(grid_size.is_definite()); - switch (grid_size.type()) { - case CSS::GridSize::Type::LengthPercentage: { - if (!grid_size.length_percentage().is_auto()) { - return grid_size.css_size().to_px(grid_container(), available_space.width.to_px_or_zero()); - } - break; - } - default: - VERIFY_NOT_REACHED(); - } - return 0; + if (grid_size.type() == CSS::GridSize::Type::LengthPercentage) + return grid_size.css_size().to_px(grid_container(), available_space.width.to_px_or_zero()); + VERIFY_NOT_REACHED(); } int GridFormattingContext::count_of_repeated_auto_fill_or_fit_tracks(GridDimension dimension, CSS::ExplicitGridTrack const& repeated_track) diff --git a/Libraries/LibWeb/Layout/GridFormattingContext.h b/Libraries/LibWeb/Layout/GridFormattingContext.h index db22802ac83..016210763e1 100644 --- a/Libraries/LibWeb/Layout/GridFormattingContext.h +++ b/Libraries/LibWeb/Layout/GridFormattingContext.h @@ -329,7 +329,7 @@ private: AvailableSize get_free_space(AvailableSpace const&, GridDimension) const; Optional get_nth_line_index_by_line_name(GridDimension dimension, String const&, int line_number); - CSSPixels resolve_definite_track_size(CSS::GridSize const&, AvailableSpace const&); + CSSPixels resolve_definite_track_size(CSS::GridSize const&, AvailableSpace const&) const; int count_of_repeated_auto_fill_or_fit_tracks(GridDimension, CSS::ExplicitGridTrack const& repeated_track); void build_grid_areas();