mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-13 03:29:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibIDL: Fix use-after-free in GenerateWindowOrWorkerInterfaces

Browse source 
`lexical_bases` was storing `StringView`s into `ByteString`s returned
from `LexicalPath::string()` that might no longer exist.
This commit is contained in:
Jonne Ransijn 2024-11-15 23:43:04 +01:00 • committed by Andreas Kling
commit c3783cf3bd
Notes: github-actions[bot] 2024-11-16 13:40:52 +00:00
4 changed files with 8 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibIDL/IDLParser.h
View file

@ -17,7 +17,7 @@ namespace IDL {
class Parser {
public:
Parser(ByteString filename, StringView contents, Vector<StringView> import_base_paths);
Parser(ByteString filename, StringView contents, Vector<ByteString> import_base_paths);
Interface& parse();
Vector<ByteString> imported_files() const;
@ -35,7 +35,7 @@ private:
Yes,
};
Parser(Parser* parent, ByteString filename, StringView contents, Vector<StringView> import_base_path);
Parser(Parser* parent, ByteString filename, StringView contents, Vector<ByteString> import_base_path);
void assert_specific(char ch);
void assert_string(StringView expected);
@ -68,7 +68,7 @@ private:
ByteString parse_identifier_ending_with_space();
ByteString parse_identifier_ending_with_space_or(auto... possible_terminating_characters);
Vector<StringView> import_base_paths;
Vector<ByteString> import_base_paths;
ByteString filename;
StringView input;
LineTrackingLexer lexer;