From c4889f3c5c39d1e37d4e08b48190e267cca2d3c3 Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Thu, 13 Feb 2025 12:55:12 +0000 Subject: [PATCH] LibWeb/DOM: Stop moving `is_value` in `create_element()` Clangd points out that 1) `set_is_value()` takes a reference so moving isn't useful, and 2) we're reading `is_value` in step 3 after moving it. --- Libraries/LibWeb/DOM/ElementFactory.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Libraries/LibWeb/DOM/ElementFactory.cpp b/Libraries/LibWeb/DOM/ElementFactory.cpp index 3763c10cbb6..457381fa1da 100644 --- a/Libraries/LibWeb/DOM/ElementFactory.cpp +++ b/Libraries/LibWeb/DOM/ElementFactory.cpp @@ -656,7 +656,7 @@ WebIDL::ExceptionOr> create_element(Document& document, FlyStri if (namespace_ == Namespace::HTML) { auto element = create_html_element(realm, document, move(qualified_name)); - element->set_is_value(move(is_value)); + element->set_is_value(is_value); element->set_custom_element_state(CustomElementState::Uncustomized); // 3. If namespace is the HTML namespace, and either localName is a valid custom element name or is is non-null, @@ -669,14 +669,14 @@ WebIDL::ExceptionOr> create_element(Document& document, FlyStri if (namespace_ == Namespace::SVG) { auto element = create_svg_element(realm, document, qualified_name); - element->set_is_value(move(is_value)); + element->set_is_value(is_value); element->set_custom_element_state(CustomElementState::Uncustomized); return element; } if (namespace_ == Namespace::MathML) { auto element = create_mathml_element(realm, document, qualified_name); - element->set_is_value(move(is_value)); + element->set_is_value(is_value); element->set_custom_element_state(CustomElementState::Uncustomized); return element; }