mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-05 15:49:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Move and rename CSSStyleValue to StyleValues/StyleValue.{h,cpp}

Browse source 
This reverts 0e3487b9ab.

Back when I made that change, I thought we could make our StyleValue
classes match the typed-om definitions directly. However, they have
different requirements. Typed-om types need to be mutable and GCed,
whereas StyleValues are immutable and ideally wouldn't require a JS VM.

While I was already making such a cataclysmic change, I've moved it into
the StyleValues directory, because it *not* being there has bothered me
for a long time. 😅
This commit is contained in:
Sam Atkins 2025-08-08 10:11:51 +01:00 • committed by Tim Ledbetter
commit c57975c9fd
Notes: github-actions[bot] 2025-08-08 14:20:54 +00:00
167 changed files with 989 additions and 990 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/CSS/StyleValues/UnresolvedStyleValue.cpp
View file

@ -29,7 +29,7 @@ ValueComparingNonnullRefPtr<UnresolvedStyleValue const> UnresolvedStyleValue::cr
}
UnresolvedStyleValue::UnresolvedStyleValue(Vector<Parser::ComponentValue>&& values, Parser::SubstitutionFunctionsPresence substitution_presence, Optional<String> original_source_text)
: CSSStyleValue(Type::Unresolved)
: StyleValue(Type::Unresolved)
, m_values(move(values))
, m_substitution_functions_presence(substitution_presence)
, m_original_source_text(move(original_source_text))
@ -44,7 +44,7 @@ String UnresolvedStyleValue::to_string(SerializationMode) const
return serialize_a_series_of_component_values(m_values, InsertWhitespace::Yes);
}
bool UnresolvedStyleValue::equals(CSSStyleValue const& other) const
bool UnresolvedStyleValue::equals(StyleValue const& other) const
{
if (type() != other.type())
return false;