Shell: Allow redirections and pipes on builtins

Fixes #3072.
Author: https://github.com/alimpfard Commit: c589625418 Pull-request: https://github.com/SerenityOS/serenity/pull/3144 Issue: https://github.com/SerenityOS/serenity/issues/3072 Reviewed-by: https://github.com/awesomekling
2025-06-24 11:11:51 +00:00 · 2020-08-14 22:30:48 +04:30 · 2020-08-14 22:30:48 +04:30 · c589625418 · 2024-07-19 03:36:12 +09:00
commit c589625418
parent 0dac7af6c5
6 changed files with 81 additions and 13 deletions
--- a/Shell/Shell.cpp
+++ b/Shell/Shell.cpp
@ -500,6 +500,10 @@ RefPtr<Job> Shell::run_command(const AST::Command& command)
            return nullptr;
    }

+    int retval = 0;
+    if (run_builtin(command, rewirings, retval))
+        return nullptr;
+
    Vector<const char*> argv;
    Vector<String> copy_argv = command.argv;
    argv.ensure_capacity(command.argv.size() + 1);
@ -509,10 +513,6 @@ RefPtr<Job> Shell::run_command(const AST::Command& command)

    argv.append(nullptr);

-    int retval = 0;
-    if (run_builtin(argv.size() - 1, argv.data(), retval))
-        return nullptr;
-
    int sync_pipe[2];
    if (pipe(sync_pipe) < 0) {
        perror("pipe");