From c647ac407ddcb12d012329af976a673e61a952b2 Mon Sep 17 00:00:00 2001
From: Shannon Booth <shannon@serenityos.org>
Date: Mon, 27 Jan 2025 12:08:36 +1300
Subject: [PATCH] LibWeb/HTML: Avoid double lookup of size attribute

---
 Libraries/LibWeb/HTML/HTMLSelectElement.cpp | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/Libraries/LibWeb/HTML/HTMLSelectElement.cpp b/Libraries/LibWeb/HTML/HTMLSelectElement.cpp
index ef6415ca4c6..a96862e45b8 100644
--- a/Libraries/LibWeb/HTML/HTMLSelectElement.cpp
+++ b/Libraries/LibWeb/HTML/HTMLSelectElement.cpp
@@ -297,11 +297,9 @@ Optional<ARIA::Role> HTMLSelectElement::default_role() const
     // https://www.w3.org/TR/html-aria/#el-select-multiple-or-size-greater-1
     if (has_attribute(AttributeNames::multiple))
         return ARIA::Role::listbox;
-    if (has_attribute(AttributeNames::size)) {
-        if (auto size_string = get_attribute(HTML::AttributeNames::size); size_string.has_value()) {
-            if (auto size = size_string->to_number<int>(); size.has_value() && *size > 1)
-                return ARIA::Role::listbox;
-        }
+    if (auto size_string = get_attribute(HTML::AttributeNames::size); size_string.has_value()) {
+        if (auto size = size_string->to_number<int>(); size.has_value() && *size > 1)
+            return ARIA::Role::listbox;
     }
     // https://www.w3.org/TR/html-aria/#el-select
     return ARIA::Role::combobox;