From c6d848b100c5a8216d4ac83b20f19be2cdcae735 Mon Sep 17 00:00:00 2001
From: Jelle Raaijmakers <jelle@ladybird.org>
Date: Sun, 22 Jun 2025 09:52:34 +0200
Subject: [PATCH] CI: Disable the Windows CI job by using a boolean exclusion

Each matrix item now defines whether it is enabled, and if not, the job
conditionally disables itself. Apparantly we cannot use expressions in
`matrix.exclude`, but it should work in the items' definitions.

This has the added benefit that this makes the job show up as "skipped",
which could serve as a hint that it could be run on a PR.
---
 .github/workflows/ci.yml             | 13 +++++++++----
 .github/workflows/lagom-template.yml |  5 +++++
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 327d3b3646a..92a1b8577c8 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -16,6 +16,9 @@ concurrency:
 jobs:
   # CI matrix - runs the job in lagom-template.yml with different configurations.
   Lagom:
+    # Run the items in this matrix only if:
+    # 1. The repository is the Ladybird repository; and
+    # 2. If the event was a push event, or a PR event other than 'labeled', or the label name is 'windows'
     if: |
       github.repository == 'LadybirdBrowser/ladybird'
       && (github.event_name != 'pull_request' || github.event.action != 'labeled' || github.event.label.name == 'windows')
@@ -30,6 +33,7 @@ jobs:
         toolchain: ['GNU']
         clang_plugins: [false]
         runner_labels: ['["blacksmith-16vcpu-ubuntu-2404"]']
+        enabled: [true]
 
         include:
           - os_name: 'Linux'
@@ -38,6 +42,7 @@ jobs:
             toolchain: 'Clang'
             clang_plugins: true
             runner_labels: '["blacksmith-16vcpu-ubuntu-2404"]'
+            enabled: true
 
           - os_name: 'macOS'
             arch: 'arm64'
@@ -45,6 +50,7 @@ jobs:
             toolchain: 'Clang'
             clang_plugins: false
             runner_labels: '["macos-15", "self-hosted"]'
+            enabled: true
 
           - os_name: 'Linux'
             arch: 'x86_64'
@@ -52,6 +58,7 @@ jobs:
             toolchain: 'Clang'
             clang_plugins: false
             runner_labels: '["blacksmith-16vcpu-ubuntu-2404"]'
+            enabled: true
 
           - os_name: 'Windows'
             arch: 'x86_64'
@@ -59,10 +66,7 @@ jobs:
             toolchain: 'ClangCL'
             clang_plugins: false
             runner_labels: '["windows-2025"]'
-
-        exclude:
-          # Exclude the Windows build from the matrix if the PR is not labeled with 'windows'.
-          - os_name: ${{ !contains(github.event.pull_request.labels.*.name, 'windows') && 'Windows' }}
+            enabled: ${{ contains(github.event.pull_request.labels.*.name, 'windows') }}
 
     uses: ./.github/workflows/lagom-template.yml
     with:
@@ -72,3 +76,4 @@ jobs:
       arch: ${{ matrix.arch }}
       build_preset: ${{ matrix.build_preset }}
       clang_plugins: ${{ matrix.clang_plugins }}
+      enabled: ${{ matrix.enabled }}
diff --git a/.github/workflows/lagom-template.yml b/.github/workflows/lagom-template.yml
index 62fac3d97e9..68ec4c8f454 100644
--- a/.github/workflows/lagom-template.yml
+++ b/.github/workflows/lagom-template.yml
@@ -22,6 +22,10 @@ on:
         required: false
         type: boolean
         default: false
+      enabled:
+        required: false
+        type: boolean
+        default: true
 
 env:
   # runner.workspace = /home/runner/work/ladybird
@@ -38,6 +42,7 @@ env:
 
 jobs:
   CI:
+    if: ${{ inputs.enabled }}
     runs-on: ${{ fromJSON(inputs.runner_labels) }}
 
     steps: