From c700bfaaf18a4e2776ad978a737f8a2600f636e4 Mon Sep 17 00:00:00 2001 From: stelar7 Date: Thu, 8 May 2025 23:36:31 +0200 Subject: [PATCH] LibWeb/IDB: Implement IDBObjectStore::getAll --- Libraries/LibWeb/IndexedDB/IDBObjectStore.cpp | 31 +++++++++++++++++++ Libraries/LibWeb/IndexedDB/IDBObjectStore.h | 1 + Libraries/LibWeb/IndexedDB/IDBObjectStore.idl | 2 +- 3 files changed, 33 insertions(+), 1 deletion(-) diff --git a/Libraries/LibWeb/IndexedDB/IDBObjectStore.cpp b/Libraries/LibWeb/IndexedDB/IDBObjectStore.cpp index 92491b96245..573b70c8c2c 100644 --- a/Libraries/LibWeb/IndexedDB/IDBObjectStore.cpp +++ b/Libraries/LibWeb/IndexedDB/IDBObjectStore.cpp @@ -537,4 +537,35 @@ WebIDL::ExceptionOr> IDBObjectStore::get_key(JS::Value query return result; } +// https://w3c.github.io/IndexedDB/#dom-idbobjectstore-getall +WebIDL::ExceptionOr> IDBObjectStore::get_all(Optional value, Optional count) +{ + auto& realm = this->realm(); + + // 1. Let transaction be this’s transaction. + auto transaction = this->transaction(); + + // 2. Let store be this’s object store. + auto store = this->store(); + + // FIXME: 3. If store has been deleted, throw an "InvalidStateError" DOMException. + + // 4. If transaction’s state is not active, then throw a "TransactionInactiveError" DOMException. + if (transaction->state() != IDBTransaction::TransactionState::Active) + return WebIDL::TransactionInactiveError::create(realm, "Transaction is not active while getting all"_string); + + // 5. Let range be the result of converting a value to a key range with query. Rethrow any exceptions. + auto range = TRY(convert_a_value_to_a_key_range(realm, move(value))); + + // 6. Let operation be an algorithm to run retrieve multiple values from an object store with the current Realm record, store, range, and count if given. + auto operation = GC::Function()>::create(realm.heap(), [&realm, store, range, count] -> WebIDL::ExceptionOr { + return retrieve_multiple_values_from_an_object_store(realm, store, range, count); + }); + + // 7. Return the result (an IDBRequest) of running asynchronously execute a request with this and operation. + auto result = asynchronously_execute_a_request(realm, GC::Ref(*this), operation); + dbgln_if(IDB_DEBUG, "Executing request for get all with uuid {}", result->uuid()); + return result; +} + } diff --git a/Libraries/LibWeb/IndexedDB/IDBObjectStore.h b/Libraries/LibWeb/IndexedDB/IDBObjectStore.h index b7793f04dd9..5817ed2ec0e 100644 --- a/Libraries/LibWeb/IndexedDB/IDBObjectStore.h +++ b/Libraries/LibWeb/IndexedDB/IDBObjectStore.h @@ -55,6 +55,7 @@ public: [[nodiscard]] WebIDL::ExceptionOr> delete_(JS::Value); [[nodiscard]] WebIDL::ExceptionOr> clear(); [[nodiscard]] WebIDL::ExceptionOr> get_key(JS::Value); + [[nodiscard]] WebIDL::ExceptionOr> get_all(Optional, Optional); protected: explicit IDBObjectStore(JS::Realm&, GC::Ref, GC::Ref); diff --git a/Libraries/LibWeb/IndexedDB/IDBObjectStore.idl b/Libraries/LibWeb/IndexedDB/IDBObjectStore.idl index daa26684672..5e64fcd56a4 100644 --- a/Libraries/LibWeb/IndexedDB/IDBObjectStore.idl +++ b/Libraries/LibWeb/IndexedDB/IDBObjectStore.idl @@ -16,7 +16,7 @@ interface IDBObjectStore { [NewObject] IDBRequest clear(); [NewObject] IDBRequest get(any query); [NewObject] IDBRequest getKey(any query); - [FIXME, NewObject] IDBRequest getAll(optional any query, optional [EnforceRange] unsigned long count); + [NewObject] IDBRequest getAll(optional any query, optional [EnforceRange] unsigned long count); [FIXME, NewObject] IDBRequest getAllKeys(optional any query, optional [EnforceRange] unsigned long count); [NewObject] IDBRequest count(optional any query); [NewObject] IDBRequest openCursor(optional any query, optional IDBCursorDirection direction = "next");