mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-07 00:29:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Stop radio buttons firing change events when losing focus

Browse source
This commit is contained in:
Psychpsyo 2024-11-22 13:05:10 +01:00 • committed by Tim Ledbetter
commit c75dda8f8b
Notes: github-actions[bot] 2024-11-22 13:59:41 +00:00
3 changed files with 25 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -638,6 +638,7 @@ void HTMLInputElement::commit_pending_changes()
case TypeAttributeState::Text: case TypeAttributeState::Text:
case TypeAttributeState::URL: case TypeAttributeState::URL:
case TypeAttributeState::Checkbox: case TypeAttributeState::Checkbox:
case TypeAttributeState::RadioButton:
if (!m_has_uncommitted_changes) if (!m_has_uncommitted_changes)
return; return;
break; break;

1
Tests/LibWeb/Text/expected/radio-button-focus-lost-no-change-event.txt Normal file
View file

@ -0,0 +1 @@
PASS: Change event was not fired

23
Tests/LibWeb/Text/input/radio-button-focus-lost-no-change-event.html Normal file
View file

@ -0,0 +1,23 @@
<!DOCTYPE html>
<input type="radio" id="radioButton">
<script src="include.js"></script>
<script>
let changeEventFired = false;
radioButton.addEventListener("change", () => {
changeEventFired = true;
});
asyncTest(async done => {
radioButton.focus();
await new Promise(resolve => setTimeout(resolve, 0));
radioButton.blur();
await new Promise(resolve => setTimeout(resolve, 0));
if (changeEventFired) {
println("FAIL: Change event was fired when it shouldn't have been.");
} else {
println("PASS: Change event was not fired");
}
done();
});
</script>