mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-28 04:09:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Ensure anchor node is not null when extending selection

Browse source 
Previously, clicking while holding shift without having previously made
any text selection would cause a crash.
This commit is contained in:
Tim Ledbetter 2024-06-05 17:20:58 +01:00 • committed by Tim Flynn
commit c79041344d
Notes: sideshowbarker 2024-07-17 09:47:09 +09:00
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibWeb/Page/EventHandler.cpp
View file

@ -433,8 +433,9 @@ bool EventHandler::handle_mousedown(CSSPixelPoint viewport_position, CSSPixelPoi
auto& realm = document->realm();
m_navigable->set_cursor_position(DOM::Position::create(realm, *paintable->dom_node(), result->index_in_node));
if (auto selection = document->get_selection()) {
if (modifiers & KeyModifier::Mod_Shift) {
(void)selection->set_base_and_extent(*selection->anchor_node(), selection->anchor_offset(), *paintable->dom_node(), result->index_in_node);
auto anchor_node = selection->anchor_node();
if (anchor_node && modifiers & KeyModifier::Mod_Shift) {
(void)selection->set_base_and_extent(*anchor_node, selection->anchor_offset(), *paintable->dom_node(), result->index_in_node);
} else {
(void)selection->set_base_and_extent(*paintable->dom_node(), result->index_in_node, *paintable->dom_node(), result->index_in_node);
}