mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 12:19:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/WebAudio: Implement automation rate constraints

Browse source 
Some nodes have parameters whose automation rate is not allowed to be
changed. This change enforces that constraint for all parameters it
applies to.
This commit is contained in:
Tim Ledbetter 2025-01-19 03:47:18 +00:00 • committed by Andreas Kling
commit c87f80454b
Notes: github-actions[bot] 2025-01-19 16:25:50 +00:00
6 changed files with 316 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibWeb/WebAudio/AudioParam.cpp
View file

@ -14,7 +14,7 @@ namespace Web::WebAudio {
GC_DEFINE_ALLOCATOR(AudioParam);
AudioParam::AudioParam(JS::Realm& realm, GC::Ref<BaseAudioContext> context, float default_value, float min_value, float max_value, Bindings::AutomationRate automation_rate)
AudioParam::AudioParam(JS::Realm& realm, GC::Ref<BaseAudioContext> context, float default_value, float min_value, float max_value, Bindings::AutomationRate automation_rate, FixedAutomationRate fixed_automation_rate)
: Bindings::PlatformObject(realm)
, m_context(context)
, m_current_value(default_value)
@ -22,12 +22,13 @@ AudioParam::AudioParam(JS::Realm& realm, GC::Ref<BaseAudioContext> context, floa
, m_min_value(min_value)
, m_max_value(max_value)
, m_automation_rate(automation_rate)
, m_fixed_automation_rate(fixed_automation_rate)
{
}
GC::Ref<AudioParam> AudioParam::create(JS::Realm& realm, GC::Ref<BaseAudioContext> context, float default_value, float min_value, float max_value, Bindings::AutomationRate automation_rate)
GC::Ref<AudioParam> AudioParam::create(JS::Realm& realm, GC::Ref<BaseAudioContext> context, float default_value, float min_value, float max_value, Bindings::AutomationRate automation_rate, FixedAutomationRate fixed_automation_rate)
{
return realm.create<AudioParam>(realm, context, default_value, min_value, max_value, automation_rate);
return realm.create<AudioParam>(realm, context, default_value, min_value, max_value, automation_rate, fixed_automation_rate);
}
AudioParam::~AudioParam() = default;
@ -56,7 +57,9 @@ Bindings::AutomationRate AudioParam::automation_rate() const
// https://webaudio.github.io/web-audio-api/#dom-audioparam-automationrate
WebIDL::ExceptionOr<void> AudioParam::set_automation_rate(Bindings::AutomationRate automation_rate)
{
dbgln("FIXME: Fully implement AudioParam::set_automation_rate");
if (automation_rate != m_automation_rate && m_fixed_automation_rate == FixedAutomationRate::Yes)
return WebIDL::InvalidStateError::create(realm(), "Automation rate cannot be changed"_string);
m_automation_rate = automation_rate;
return {};
}