mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 12:19:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

AK: Return NonnullRefPtr from StringImpl::create methods

Browse source 
None of these return a nullptr.
This commit is contained in:
Timothy Flynn 2025-04-06 09:53:04 -04:00 • committed by Andreas Kling
commit c8bb3030fd
Notes: github-actions[bot] 2025-04-07 15:46:04 +00:00
4 changed files with 24 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

14
AK/ByteString.cpp
View file

@ -59,7 +59,7 @@ ByteString ByteString::isolated_copy() const
char* buffer;
auto impl = StringImpl::create_uninitialized(length(), buffer);
memcpy(buffer, m_impl->characters(), m_impl->length());
return ByteString(move(*impl));
return impl;
}
ByteString ByteString::substring(size_t start, size_t length) const
@ -185,7 +185,7 @@ ByteString ByteString::repeated(char ch, size_t count)
char* buffer;
auto impl = StringImpl::create_uninitialized(count, buffer);
memset(buffer, ch, count);
return *impl;
return impl;
}
ByteString ByteString::repeated(StringView string, size_t count)
@ -196,7 +196,7 @@ ByteString ByteString::repeated(StringView string, size_t count)
auto impl = StringImpl::create_uninitialized(count * string.length(), buffer);
for (size_t i = 0; i < count; i++)
__builtin_memcpy(buffer + i * string.length(), string.characters_without_null_termination(), string.length());
return *impl;
return impl;
}
ByteString ByteString::bijective_base_from(size_t value, unsigned base, StringView map)
@ -334,7 +334,7 @@ ByteString escape_html_entities(StringView html)
}
ByteString::ByteString(FlyString const& string)
: m_impl(*StringImpl::create(string.bytes()))
: m_impl(StringImpl::create(string.bytes()))
{
}
@ -349,7 +349,7 @@ ByteString ByteString::to_lowercase() const
for (auto [i, character] : enumerate(view()))
buffer[i] = static_cast<char>(to_ascii_lowercase(character));
return *impl;
return impl;
}
ByteString ByteString::to_uppercase() const
@ -363,7 +363,7 @@ ByteString ByteString::to_uppercase() const
for (auto [i, character] : enumerate(view()))
buffer[i] = static_cast<char>(to_ascii_uppercase(character));
return *impl;
return impl;
}
ByteString ByteString::to_snakecase() const
@ -410,7 +410,7 @@ ErrorOr<ByteString> ByteString::from_utf8(ReadonlyBytes bytes)
{
if (!Utf8View(bytes).validate())
return Error::from_string_literal("ByteString::from_utf8: Input was not valid UTF-8");
return ByteString { *StringImpl::create(bytes) };
return StringImpl::create(bytes);
}
}