mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-02 22:30:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Use separate restore() for each ApplyFilters display list item

Browse source 
ApplyFilter internally calls canvas.saveLayer() which requires a
matching canvas.restore() to be called.

Fixes painting on https://supabase.com/ regressed by
8562b0e33b
This commit is contained in:
Aliaksandr Kalenik 2024-12-01 15:26:20 +01:00 • committed by Andreas Kling
commit c94b4316e7
Notes: github-actions[bot] 2024-12-01 15:13:10 +00:00
2 changed files with 18 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibWeb/Painting/StackingContext.cpp
View file

@ -327,7 +327,11 @@ void StackingContext::paint(PaintContext& context) const
context.display_list_recorder().push_scroll_frame_id(*paintable_box().scroll_frame_id());
}
context.display_list_recorder().push_stacking_context(push_stacking_context_params);
context.display_list_recorder().apply_filters(paintable_box().computed_values().filter());
auto const& filter = computed_values.filter();
if (!filter.is_none()) {
context.display_list_recorder().apply_filters(paintable_box().computed_values().filter());
}
if (auto mask_image = computed_values.mask_image()) {
auto mask_display_list = DisplayList::create();
@ -348,6 +352,10 @@ void StackingContext::paint(PaintContext& context) const
}
}
if (!filter.is_none()) {
context.display_list_recorder().restore();
}
paint_internal(context);
context.display_list_recorder().pop_stacking_context();
if (paintable_box().scroll_frame_id().has_value()) {