From c9cbaeb59d6f699b33bf3924688987b3ca917fee Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Wed, 2 Oct 2024 12:58:07 -0400 Subject: [PATCH] LibWeb: Convert some sync tests to be async The events tested here are decidedly async. We also can't really write sync tests of the form "test(async () => {})". Nothing will await the async callback. --- .../Text/input/Fetch/fetch-response-url-encoded.html | 3 ++- .../input/HTML/HTMLMediaElement-addTextTrack.html | 3 ++- Tests/LibWeb/Text/input/HTML/data-transfer.html | 4 +++- .../Streams/ReadableStream-from-asyncIterator.html | 4 ++-- Tests/LibWeb/Text/input/base/link-element-base.html | 3 ++- .../Text/input/link-element-media-attribute.html | 3 ++- .../Text/input/link-element-media-change-off.html | 3 ++- .../LibWeb/Text/input/link-element-media-change.html | 3 ++- .../Text/input/link-element-onload-attribute.html | 6 ++++-- .../input/link-element-rel-preload-load-event.html | 12 +++++++++++- 10 files changed, 32 insertions(+), 12 deletions(-) diff --git a/Tests/LibWeb/Text/input/Fetch/fetch-response-url-encoded.html b/Tests/LibWeb/Text/input/Fetch/fetch-response-url-encoded.html index 37f2fc88b86..fe9370fb7ce 100644 --- a/Tests/LibWeb/Text/input/Fetch/fetch-response-url-encoded.html +++ b/Tests/LibWeb/Text/input/Fetch/fetch-response-url-encoded.html @@ -1,6 +1,6 @@ diff --git a/Tests/LibWeb/Text/input/HTML/HTMLMediaElement-addTextTrack.html b/Tests/LibWeb/Text/input/HTML/HTMLMediaElement-addTextTrack.html index f0db66cd092..c97f0c3a3a5 100644 --- a/Tests/LibWeb/Text/input/HTML/HTMLMediaElement-addTextTrack.html +++ b/Tests/LibWeb/Text/input/HTML/HTMLMediaElement-addTextTrack.html @@ -1,10 +1,11 @@ diff --git a/Tests/LibWeb/Text/input/Streams/ReadableStream-from-asyncIterator.html b/Tests/LibWeb/Text/input/Streams/ReadableStream-from-asyncIterator.html index 9d4a4a2ca5b..65cf4a257ab 100644 --- a/Tests/LibWeb/Text/input/Streams/ReadableStream-from-asyncIterator.html +++ b/Tests/LibWeb/Text/input/Streams/ReadableStream-from-asyncIterator.html @@ -18,13 +18,13 @@ } } - test(async () => { + asyncTest(done => { const asyncIterable = { [Symbol.asyncIterator]: asyncGenerator, }; const readableStream = ReadableStream.from(asyncIterable); - await readStream(readableStream); + readStream(readableStream).then(done); }); diff --git a/Tests/LibWeb/Text/input/base/link-element-base.html b/Tests/LibWeb/Text/input/base/link-element-base.html index e5ceeadd22d..ad09e9e19c1 100644 --- a/Tests/LibWeb/Text/input/base/link-element-base.html +++ b/Tests/LibWeb/Text/input/base/link-element-base.html @@ -7,9 +7,10 @@ diff --git a/Tests/LibWeb/Text/input/link-element-media-attribute.html b/Tests/LibWeb/Text/input/link-element-media-attribute.html index 30016e28570..eb3a5013326 100644 --- a/Tests/LibWeb/Text/input/link-element-media-attribute.html +++ b/Tests/LibWeb/Text/input/link-element-media-attribute.html @@ -5,7 +5,7 @@ diff --git a/Tests/LibWeb/Text/input/link-element-media-change-off.html b/Tests/LibWeb/Text/input/link-element-media-change-off.html index 4fc56974c25..3ab0c782c67 100644 --- a/Tests/LibWeb/Text/input/link-element-media-change-off.html +++ b/Tests/LibWeb/Text/input/link-element-media-change-off.html @@ -6,9 +6,10 @@ diff --git a/Tests/LibWeb/Text/input/link-element-media-change.html b/Tests/LibWeb/Text/input/link-element-media-change.html index 9cb18a9a3aa..1ffdcdbb05c 100644 --- a/Tests/LibWeb/Text/input/link-element-media-change.html +++ b/Tests/LibWeb/Text/input/link-element-media-change.html @@ -6,9 +6,10 @@ diff --git a/Tests/LibWeb/Text/input/link-element-onload-attribute.html b/Tests/LibWeb/Text/input/link-element-onload-attribute.html index fd74a7fb155..30f1f51d072 100644 --- a/Tests/LibWeb/Text/input/link-element-onload-attribute.html +++ b/Tests/LibWeb/Text/input/link-element-onload-attribute.html @@ -1,11 +1,13 @@ diff --git a/Tests/LibWeb/Text/input/link-element-rel-preload-load-event.html b/Tests/LibWeb/Text/input/link-element-rel-preload-load-event.html index 5cba402fc26..7e72f79e0ea 100644 --- a/Tests/LibWeb/Text/input/link-element-rel-preload-load-event.html +++ b/Tests/LibWeb/Text/input/link-element-rel-preload-load-event.html @@ -1,12 +1,18 @@