LibWeb: Replace is<T>() with as_if<T>() where possible
Some checks are pending
CI / macOS, arm64, Sanitizer, Clang (push) Waiting to run
CI / Linux, x86_64, Fuzzers, Clang (push) Waiting to run
CI / Linux, x86_64, Sanitizer, GNU (push) Waiting to run
CI / Linux, x86_64, Sanitizer, Clang (push) Waiting to run
Package the js repl as a binary artifact / Linux, arm64 (push) Waiting to run
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Lint Code / lint (push) Waiting to run
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Push notes / build (push) Waiting to run

This commit is contained in:
Tim Ledbetter 2025-08-25 07:22:57 +01:00 committed by Jelle Raaijmakers
commit cb1a1a5cb5
Notes: github-actions[bot] 2025-08-25 16:46:19 +00:00
26 changed files with 92 additions and 109 deletions

View file

@ -164,8 +164,7 @@ static bool default_passive_value(FlyString const& type, EventTarget* event_targ
if (is<HTML::Window>(event_target))
return true;
if (is<Node>(event_target)) {
auto* node = as<Node>(event_target);
if (auto* node = as_if<Node>(event_target)) {
if (&node->document() == event_target || node->document().document_element() == event_target || node->document().body() == event_target)
return true;
}
@ -400,8 +399,7 @@ WebIDL::CallbackType* EventTarget::get_current_value_of_event_handler(FlyString
GC::Ptr<Element> element;
GC::Ptr<Document> document;
if (is<Element>(this)) {
auto* element_event_target = as<Element>(this);
if (auto* element_event_target = as_if<Element>(this)) {
element = element_event_target;
document = &element_event_target->document();
} else {