From cb558f445920bca9c54c07f1328d20e697466522 Mon Sep 17 00:00:00 2001 From: "Liav A." Date: Fri, 1 Mar 2024 12:27:41 +0200 Subject: [PATCH] Kernel/Devices: Remove SerialDevice::initialize method We can just do the initialization sequence in the constructor. --- Kernel/Devices/SerialDevice.cpp | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/Kernel/Devices/SerialDevice.cpp b/Kernel/Devices/SerialDevice.cpp index ba09e5b7555..25307516838 100644 --- a/Kernel/Devices/SerialDevice.cpp +++ b/Kernel/Devices/SerialDevice.cpp @@ -16,7 +16,11 @@ SerialDevice::SerialDevice(NonnullOwnPtr registers_io_window, unsigned : CharacterDevice(4, minor) , m_registers_io_window(move(registers_io_window)) { - initialize(); + set_interrupts(false); + set_baud(Baud38400); + set_line_control(None, One, EightBits); + set_fifo_control(EnableFIFO | ClearReceiveFIFO | ClearTransmitFIFO | TriggerLevel4); + set_modem_control(RequestToSend | DataTerminalReady); } SerialDevice::~SerialDevice() = default; @@ -76,15 +80,6 @@ void SerialDevice::put_char(char ch) m_last_put_char_was_carriage_return = (ch == '\r'); } -void SerialDevice::initialize() -{ - set_interrupts(false); - set_baud(Baud38400); - set_line_control(None, One, EightBits); - set_fifo_control(EnableFIFO | ClearReceiveFIFO | ClearTransmitFIFO | TriggerLevel4); - set_modem_control(RequestToSend | DataTerminalReady); -} - void SerialDevice::set_interrupts(bool interrupt_enable) { m_interrupt_enable = interrupt_enable;