mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-28 19:59:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibURL+Everywhere: Only percent decode URL paths when actually needed

Browse source 
Web specs do not return through javascript percent decoded URL path
components - but we were doing this in a number of places due to the
default behaviour of URL::serialize_path.

Since percent encoded URL paths may not contain valid UTF-8 - this was
resulting in us crashing in these places.

For example - on an HTMLAnchorElement when retrieving the pathname for
the URL of:

http://ladybird.org/foo%C2%91%91

To fix this make the URL class only return the percent encoded
serialized path, matching the URL spec. When the decoded path is
required instead explicitly call URL::percent_decode.

This fixes a crash running WPT URL tests for the anchor element on:

https://wpt.live/url/a-element.html
This commit is contained in:
Shannon Booth 2024-08-05 16:55:39 +12:00 • committed by Andreas Kling
commit cc55732332
Notes: github-actions[bot] 2024-08-05 07:59:02 +00:00
18 changed files with 38 additions and 38 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Loader/GeneratedPagesLoader.cpp
View file

@ -42,7 +42,7 @@ ErrorOr<String> load_error_page(URL::URL const& url, StringView error_message)
ErrorOr<String> load_file_directory_page(URL::URL const& url)
{
// Generate HTML contents entries table
auto lexical_path = LexicalPath(url.serialize_path());
auto lexical_path = LexicalPath(URL::percent_decode(url.serialize_path()));
Core::DirIterator dt(lexical_path.string(), Core::DirIterator::Flags::SkipParentAndBaseDir);
Vector<ByteString> names;
while (dt.has_next())