mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 20:29:18 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Skip build of rule cache for inactive documents

Browse source 
Some websites (Reddit, for example) create lots of temporary documents
for fragment parsing. Before this change, we had to build a rule cache
for these documents just to determine whether there are :has, :defined,
or attribute selectors, while it should be safe to simply return `false`
right away.
This commit is contained in:
Aliaksandr Kalenik 2025-01-02 21:07:47 +03:00 • committed by Andreas Kling
commit ccb543ebb8
Notes: github-actions[bot] 2025-01-03 10:14:31 +00:00
1 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibWeb/CSS/StyleComputer.cpp
View file

@ -3017,20 +3017,28 @@ size_t StyleComputer::number_of_css_font_faces_with_loading_in_progress() const
bool StyleComputer::has_has_selectors() const bool StyleComputer::has_has_selectors() const
{ {
if (!document().is_active())
return false;
build_rule_cache_if_needed(); build_rule_cache_if_needed();
return m_selector_insights->has_has_selectors; return m_selector_insights->has_has_selectors;
} }
bool StyleComputer::has_defined_selectors() const bool StyleComputer::has_defined_selectors() const
{ {
if (!document().is_active())
return false;
build_rule_cache_if_needed(); build_rule_cache_if_needed();
return m_selector_insights->has_defined_selectors; return m_selector_insights->has_defined_selectors;
} }
bool StyleComputer::has_attribute_selector(FlyString const& attribute_name) const bool StyleComputer::has_attribute_selector(FlyString const& attribute_name) const
{ {
build_rule_cache_if_needed(); if (!document().is_active())
return false;
build_rule_cache_if_needed();
return m_selector_insights->all_names_used_in_attribute_selectors.contains(attribute_name); return m_selector_insights->all_names_used_in_attribute_selectors.contains(attribute_name);
} }