mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Reject trailing unparseable tokens in property values

Browse source 
Without this, we'd happily parse `font-variant-caps: small-caps potato`
as just `small-caps` and ignore the fact that unused tokens were left
over.

This fix gets us some WPT subtest passes, and removes the need for a
bespoke parsing function for font-variant-caps.
This commit is contained in:
Sam Atkins 2025-02-06 15:05:31 +00:00
commit cda3fe7a4b
Notes: github-actions[bot] 2025-02-12 16:02:07 +00:00
11 changed files with 28 additions and 62 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Tests/LibWeb/Text/expected/wpt-import/css/css-align/gaps/gap-parsing-001.txt
View file

@ -2,8 +2,8 @@ Harness status: OK
Found 26 tests
23 Pass
3 Fail
24 Pass
2 Fail
Pass Default gap is 'normal'
Pass gap accepts pixels
Pass gap accepts pixels 2
@ -28,5 +28,5 @@ Pass Angle gap is invalid
Pass Resolution gap is invalid
Pass Time gap is invalid
Pass gap with three values is invalid
Fail gap with slash is invalid
Pass gap with slash is invalid
Fail gap with one wrong value is invalid

6
Tests/LibWeb/Text/expected/wpt-import/css/css-align/gaps/grid-gap-parsing-001.txt
View file

@ -2,8 +2,8 @@ Harness status: OK
Found 26 tests
23 Pass
3 Fail
24 Pass
2 Fail
Pass Default grid-gap is 'normal'
Pass grid-gap accepts pixels
Pass grid-gap accepts pixels 2
@ -28,5 +28,5 @@ Pass Angle grid-gap is invalid
Pass Resolution grid-gap is invalid
Pass Time grid-gap is invalid
Pass grid-gap with three values is invalid
Fail grid-gap with slash is invalid
Pass grid-gap with slash is invalid
Fail grid-gap with one wrong value is invalid