From cddbe7d10f3fb16019cc452612019e5da955b90d Mon Sep 17 00:00:00 2001 From: rmg-x Date: Mon, 2 Dec 2024 19:43:51 -0600 Subject: [PATCH] LibWeb+Tests: Add internal property for echo server port --- Libraries/LibWeb/Internals/Internals.cpp | 12 ++++++++++++ Libraries/LibWeb/Internals/Internals.h | 3 +++ Libraries/LibWeb/Internals/Internals.idl | 1 + Tests/LibWeb/Text/input/include.js | 3 +-- 4 files changed, 17 insertions(+), 2 deletions(-) diff --git a/Libraries/LibWeb/Internals/Internals.cpp b/Libraries/LibWeb/Internals/Internals.cpp index 577ca4abce7..ed53bc4b75c 100644 --- a/Libraries/LibWeb/Internals/Internals.cpp +++ b/Libraries/LibWeb/Internals/Internals.cpp @@ -21,6 +21,8 @@ namespace Web::Internals { +static u16 s_echo_server_port { 0 }; + GC_DEFINE_ALLOCATOR(Internals); Internals::Internals(JS::Realm& realm) @@ -207,4 +209,14 @@ String Internals::get_computed_label(DOM::Element& element) return MUST(element.accessible_name(active_document)); } +u16 Internals::get_echo_server_port() +{ + return s_echo_server_port; +} + +void Internals::set_echo_server_port(u16 const port) +{ + s_echo_server_port = port; +} + } diff --git a/Libraries/LibWeb/Internals/Internals.h b/Libraries/LibWeb/Internals/Internals.h index 6e8584913b8..3a7549150d8 100644 --- a/Libraries/LibWeb/Internals/Internals.h +++ b/Libraries/LibWeb/Internals/Internals.h @@ -50,6 +50,9 @@ public: String get_computed_label(DOM::Element& element); + static u16 get_echo_server_port(); + static void set_echo_server_port(u16 port); + private: explicit Internals(JS::Realm&); virtual void initialize(JS::Realm&) override; diff --git a/Libraries/LibWeb/Internals/Internals.idl b/Libraries/LibWeb/Internals/Internals.idl index 00f992f4d39..87116d66044 100644 --- a/Libraries/LibWeb/Internals/Internals.idl +++ b/Libraries/LibWeb/Internals/Internals.idl @@ -39,4 +39,5 @@ interface Internals { undefined expireCookiesWithTimeOffset(long long seconds); DOMString getComputedLabel(Element element); + unsigned short getEchoServerPort(); }; diff --git a/Tests/LibWeb/Text/input/include.js b/Tests/LibWeb/Text/input/include.js index 7734ca34f15..2034a4b743c 100644 --- a/Tests/LibWeb/Text/input/include.js +++ b/Tests/LibWeb/Text/input/include.js @@ -121,8 +121,7 @@ class HTTPTestServer { } } -// FIXME: Get the port from internals -const __httpTestServer = new HTTPTestServer("http://localhost:8123"); +const __httpTestServer = new HTTPTestServer(`http://localhost:${internals.getEchoServerPort()}`); function httpTestServer() { return __httpTestServer; }