LibWeb: Use Crypto::fill_with_secure_random instead of PRNG

This commit is contained in:
rmg-x 2024-12-20 10:34:14 -06:00 committed by Ali Mohammad Pur
parent e222ccf028
commit ceb7f5f017
Notes: github-actions[bot] 2024-12-24 16:55:54 +00:00
2 changed files with 5 additions and 4 deletions

View file

@ -29,6 +29,7 @@
#include <LibCrypto/Hash/SHA2.h>
#include <LibCrypto/PK/RSA.h>
#include <LibCrypto/Padding/OAEP.h>
#include <LibCrypto/SecureRandom.h>
#include <LibJS/Runtime/Array.h>
#include <LibJS/Runtime/ArrayBuffer.h>
#include <LibJS/Runtime/DataView.h>
@ -323,8 +324,7 @@ static WebIDL::ExceptionOr<void> validate_jwk_key_ops(JS::Realm& realm, Bindings
static WebIDL::ExceptionOr<ByteBuffer> generate_random_key(JS::VM& vm, u16 const size_in_bits)
{
auto key_buffer = TRY_OR_THROW_OOM(vm, ByteBuffer::create_uninitialized(size_in_bits / 8));
// FIXME: Use a cryptographically secure random generator
fill_with_random(key_buffer);
::Crypto::fill_with_secure_random(key_buffer);
return key_buffer;
}