mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-06 08:10:02 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Only serialize CSS numbers with up to 5 decimals
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
This fixes an issue where we'd serialize some floating point numbers
with excessive precision, resulting in unpleasant-looking numbers like
0.49999999999999999 and such.

At least 90 new subtests passing on WPT, possibly more. :^)
This commit is contained in:
Andreas Kling 2025-05-18 15:59:11 +02:00 • committed by Andreas Kling
commit cef9564728
Notes: github-actions[bot] 2025-05-18 15:24:26 +00:00
2 changed files with 93 additions and 93 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/CSS/Number.cpp
View file

@ -19,7 +19,7 @@ String Number::to_string() const
return "-infinity"_string; return "-infinity"_string;
if (isnan(m_value)) if (isnan(m_value))
return "NaN"_string; return "NaN"_string;
return String::number(m_value); return MUST(String::formatted("{:.5}", m_value));
} }
} }

184
Tests/LibWeb/Text/expected/wpt-import/css/css-values/sin-cos-tan-serialize.txt
View file

@ -2,8 +2,8 @@ Harness status: OK
Found 270 tests Found 270 tests
144 Pass 234 Pass
126 Fail 36 Fail
Pass cos(0) should be specified-value-equivalent to calc(1) Pass cos(0) should be specified-value-equivalent to calc(1)
Pass cos(0) should be computed-value-equivalent to 1 Pass cos(0) should be computed-value-equivalent to 1
Pass cos(0) should be used-value-equivalent to 1 Pass cos(0) should be used-value-equivalent to 1
@ -64,96 +64,96 @@ Pass tan(0deg) should be used-value-equivalent to 0
Pass calc(tan(0deg)) should be specified-value-equivalent to calc(0) Pass calc(tan(0deg)) should be specified-value-equivalent to calc(0)
Pass calc(tan(0deg)) should be computed-value-equivalent to 0 Pass calc(tan(0deg)) should be computed-value-equivalent to 0
Pass calc(tan(0deg)) should be used-value-equivalent to 0 Pass calc(tan(0deg)) should be used-value-equivalent to 0
Fail sin(30deg) should be specified-value-equivalent to calc(0.5) Pass sin(30deg) should be specified-value-equivalent to calc(0.5)
Fail sin(30deg) should be computed-value-equivalent to 0.5 Pass sin(30deg) should be computed-value-equivalent to 0.5
Fail sin(30deg) should be used-value-equivalent to 0.5 Pass sin(30deg) should be used-value-equivalent to 0.5
Fail calc(sin(30deg)) should be specified-value-equivalent to calc(0.5) Pass calc(sin(30deg)) should be specified-value-equivalent to calc(0.5)
Fail calc(sin(30deg)) should be computed-value-equivalent to 0.5 Pass calc(sin(30deg)) should be computed-value-equivalent to 0.5
Fail calc(sin(30deg)) should be used-value-equivalent to 0.5 Pass calc(sin(30deg)) should be used-value-equivalent to 0.5
Fail sin(0.523599) should be specified-value-equivalent to calc(0.5) Pass sin(0.523599) should be specified-value-equivalent to calc(0.5)
Fail sin(0.523599) should be computed-value-equivalent to 0.5 Pass sin(0.523599) should be computed-value-equivalent to 0.5
Fail sin(0.523599) should be used-value-equivalent to 0.5 Pass sin(0.523599) should be used-value-equivalent to 0.5
Fail calc(sin(0.523599)) should be specified-value-equivalent to calc(0.5) Pass calc(sin(0.523599)) should be specified-value-equivalent to calc(0.5)
Fail calc(sin(0.523599)) should be computed-value-equivalent to 0.5 Pass calc(sin(0.523599)) should be computed-value-equivalent to 0.5
Fail calc(sin(0.523599)) should be used-value-equivalent to 0.5 Pass calc(sin(0.523599)) should be used-value-equivalent to 0.5
Fail sin(0.523599rad) should be specified-value-equivalent to calc(0.5) Pass sin(0.523599rad) should be specified-value-equivalent to calc(0.5)
Fail sin(0.523599rad) should be computed-value-equivalent to 0.5 Pass sin(0.523599rad) should be computed-value-equivalent to 0.5
Fail sin(0.523599rad) should be used-value-equivalent to 0.5 Pass sin(0.523599rad) should be used-value-equivalent to 0.5
Fail calc(sin(0.523599rad)) should be specified-value-equivalent to calc(0.5) Pass calc(sin(0.523599rad)) should be specified-value-equivalent to calc(0.5)
Fail calc(sin(0.523599rad)) should be computed-value-equivalent to 0.5 Pass calc(sin(0.523599rad)) should be computed-value-equivalent to 0.5
Fail calc(sin(0.523599rad)) should be used-value-equivalent to 0.5 Pass calc(sin(0.523599rad)) should be used-value-equivalent to 0.5
Fail sin(33.333333grad) should be specified-value-equivalent to calc(0.5) Pass sin(33.333333grad) should be specified-value-equivalent to calc(0.5)
Fail sin(33.333333grad) should be computed-value-equivalent to 0.5 Pass sin(33.333333grad) should be computed-value-equivalent to 0.5
Fail sin(33.333333grad) should be used-value-equivalent to 0.5 Pass sin(33.333333grad) should be used-value-equivalent to 0.5
Fail calc(sin(33.333333grad)) should be specified-value-equivalent to calc(0.5) Pass calc(sin(33.333333grad)) should be specified-value-equivalent to calc(0.5)
Fail calc(sin(33.333333grad)) should be computed-value-equivalent to 0.5 Pass calc(sin(33.333333grad)) should be computed-value-equivalent to 0.5
Fail calc(sin(33.333333grad)) should be used-value-equivalent to 0.5 Pass calc(sin(33.333333grad)) should be used-value-equivalent to 0.5
Fail sin(0.08333333turn) should be specified-value-equivalent to calc(0.5) Pass sin(0.08333333turn) should be specified-value-equivalent to calc(0.5)
Fail sin(0.08333333turn) should be computed-value-equivalent to 0.5 Pass sin(0.08333333turn) should be computed-value-equivalent to 0.5
Fail sin(0.08333333turn) should be used-value-equivalent to 0.5 Pass sin(0.08333333turn) should be used-value-equivalent to 0.5
Fail calc(sin(0.08333333turn)) should be specified-value-equivalent to calc(0.5) Pass calc(sin(0.08333333turn)) should be specified-value-equivalent to calc(0.5)
Fail calc(sin(0.08333333turn)) should be computed-value-equivalent to 0.5 Pass calc(sin(0.08333333turn)) should be computed-value-equivalent to 0.5
Fail calc(sin(0.08333333turn)) should be used-value-equivalent to 0.5 Pass calc(sin(0.08333333turn)) should be used-value-equivalent to 0.5
Fail cos(60deg) should be specified-value-equivalent to calc(0.5) Pass cos(60deg) should be specified-value-equivalent to calc(0.5)
Fail cos(60deg) should be computed-value-equivalent to 0.5 Pass cos(60deg) should be computed-value-equivalent to 0.5
Fail cos(60deg) should be used-value-equivalent to 0.5 Pass cos(60deg) should be used-value-equivalent to 0.5
Fail calc(cos(60deg)) should be specified-value-equivalent to calc(0.5) Pass calc(cos(60deg)) should be specified-value-equivalent to calc(0.5)
Fail calc(cos(60deg)) should be computed-value-equivalent to 0.5 Pass calc(cos(60deg)) should be computed-value-equivalent to 0.5
Fail calc(cos(60deg)) should be used-value-equivalent to 0.5 Pass calc(cos(60deg)) should be used-value-equivalent to 0.5
Fail cos(66.66666666grad) should be specified-value-equivalent to calc(0.5) Pass cos(66.66666666grad) should be specified-value-equivalent to calc(0.5)
Fail cos(66.66666666grad) should be computed-value-equivalent to 0.5 Pass cos(66.66666666grad) should be computed-value-equivalent to 0.5
Fail cos(66.66666666grad) should be used-value-equivalent to 0.5 Pass cos(66.66666666grad) should be used-value-equivalent to 0.5
Fail calc(cos(66.66666666grad)) should be specified-value-equivalent to calc(0.5) Pass calc(cos(66.66666666grad)) should be specified-value-equivalent to calc(0.5)
Fail calc(cos(66.66666666grad)) should be computed-value-equivalent to 0.5 Pass calc(cos(66.66666666grad)) should be computed-value-equivalent to 0.5
Fail calc(cos(66.66666666grad)) should be used-value-equivalent to 0.5 Pass calc(cos(66.66666666grad)) should be used-value-equivalent to 0.5
Fail cos(1.047197551) should be specified-value-equivalent to calc(0.5) Pass cos(1.047197551) should be specified-value-equivalent to calc(0.5)
Fail cos(1.047197551) should be computed-value-equivalent to 0.5 Pass cos(1.047197551) should be computed-value-equivalent to 0.5
Fail cos(1.047197551) should be used-value-equivalent to 0.5 Pass cos(1.047197551) should be used-value-equivalent to 0.5
Fail calc(cos(1.047197551)) should be specified-value-equivalent to calc(0.5) Pass calc(cos(1.047197551)) should be specified-value-equivalent to calc(0.5)
Fail calc(cos(1.047197551)) should be computed-value-equivalent to 0.5 Pass calc(cos(1.047197551)) should be computed-value-equivalent to 0.5
Fail calc(cos(1.047197551)) should be used-value-equivalent to 0.5 Pass calc(cos(1.047197551)) should be used-value-equivalent to 0.5
Fail cos(1.047197551rad) should be specified-value-equivalent to calc(0.5) Pass cos(1.047197551rad) should be specified-value-equivalent to calc(0.5)
Fail cos(1.047197551rad) should be computed-value-equivalent to 0.5 Pass cos(1.047197551rad) should be computed-value-equivalent to 0.5
Fail cos(1.047197551rad) should be used-value-equivalent to 0.5 Pass cos(1.047197551rad) should be used-value-equivalent to 0.5
Fail calc(cos(1.047197551rad)) should be specified-value-equivalent to calc(0.5) Pass calc(cos(1.047197551rad)) should be specified-value-equivalent to calc(0.5)
Fail calc(cos(1.047197551rad)) should be computed-value-equivalent to 0.5 Pass calc(cos(1.047197551rad)) should be computed-value-equivalent to 0.5
Fail calc(cos(1.047197551rad)) should be used-value-equivalent to 0.5 Pass calc(cos(1.047197551rad)) should be used-value-equivalent to 0.5
Fail cos(0.16666666666turn) should be specified-value-equivalent to calc(0.5) Pass cos(0.16666666666turn) should be specified-value-equivalent to calc(0.5)
Fail cos(0.16666666666turn) should be computed-value-equivalent to 0.5 Pass cos(0.16666666666turn) should be computed-value-equivalent to 0.5
Fail cos(0.16666666666turn) should be used-value-equivalent to 0.5 Pass cos(0.16666666666turn) should be used-value-equivalent to 0.5
Fail calc(cos(0.16666666666turn)) should be specified-value-equivalent to calc(0.5) Pass calc(cos(0.16666666666turn)) should be specified-value-equivalent to calc(0.5)
Fail calc(cos(0.16666666666turn)) should be computed-value-equivalent to 0.5 Pass calc(cos(0.16666666666turn)) should be computed-value-equivalent to 0.5
Fail calc(cos(0.16666666666turn)) should be used-value-equivalent to 0.5 Pass calc(cos(0.16666666666turn)) should be used-value-equivalent to 0.5
Fail tan(45deg) should be specified-value-equivalent to calc(1) Pass tan(45deg) should be specified-value-equivalent to calc(1)
Fail tan(45deg) should be computed-value-equivalent to 1 Pass tan(45deg) should be computed-value-equivalent to 1
Fail tan(45deg) should be used-value-equivalent to 1 Pass tan(45deg) should be used-value-equivalent to 1
Fail calc(tan(45deg)) should be specified-value-equivalent to calc(1) Pass calc(tan(45deg)) should be specified-value-equivalent to calc(1)
Fail calc(tan(45deg)) should be computed-value-equivalent to 1 Pass calc(tan(45deg)) should be computed-value-equivalent to 1
Fail calc(tan(45deg)) should be used-value-equivalent to 1 Pass calc(tan(45deg)) should be used-value-equivalent to 1
Fail tan(50grad) should be specified-value-equivalent to calc(1) Pass tan(50grad) should be specified-value-equivalent to calc(1)
Fail tan(50grad) should be computed-value-equivalent to 1 Pass tan(50grad) should be computed-value-equivalent to 1
Fail tan(50grad) should be used-value-equivalent to 1 Pass tan(50grad) should be used-value-equivalent to 1
Fail calc(tan(50grad)) should be specified-value-equivalent to calc(1) Pass calc(tan(50grad)) should be specified-value-equivalent to calc(1)
Fail calc(tan(50grad)) should be computed-value-equivalent to 1 Pass calc(tan(50grad)) should be computed-value-equivalent to 1
Fail calc(tan(50grad)) should be used-value-equivalent to 1 Pass calc(tan(50grad)) should be used-value-equivalent to 1
Fail tan(0.78539816) should be specified-value-equivalent to calc(1) Pass tan(0.78539816) should be specified-value-equivalent to calc(1)
Fail tan(0.78539816) should be computed-value-equivalent to 1 Pass tan(0.78539816) should be computed-value-equivalent to 1
Fail tan(0.78539816) should be used-value-equivalent to 1 Pass tan(0.78539816) should be used-value-equivalent to 1
Fail calc(tan(0.78539816)) should be specified-value-equivalent to calc(1) Pass calc(tan(0.78539816)) should be specified-value-equivalent to calc(1)
Fail calc(tan(0.78539816)) should be computed-value-equivalent to 1 Pass calc(tan(0.78539816)) should be computed-value-equivalent to 1
Fail calc(tan(0.78539816)) should be used-value-equivalent to 1 Pass calc(tan(0.78539816)) should be used-value-equivalent to 1
Fail tan(0.78539816rad) should be specified-value-equivalent to calc(1) Pass tan(0.78539816rad) should be specified-value-equivalent to calc(1)
Fail tan(0.78539816rad) should be computed-value-equivalent to 1 Pass tan(0.78539816rad) should be computed-value-equivalent to 1
Fail tan(0.78539816rad) should be used-value-equivalent to 1 Pass tan(0.78539816rad) should be used-value-equivalent to 1
Fail calc(tan(0.78539816rad)) should be specified-value-equivalent to calc(1) Pass calc(tan(0.78539816rad)) should be specified-value-equivalent to calc(1)
Fail calc(tan(0.78539816rad)) should be computed-value-equivalent to 1 Pass calc(tan(0.78539816rad)) should be computed-value-equivalent to 1
Fail calc(tan(0.78539816rad)) should be used-value-equivalent to 1 Pass calc(tan(0.78539816rad)) should be used-value-equivalent to 1
Fail tan(0.125turn) should be specified-value-equivalent to calc(1) Pass tan(0.125turn) should be specified-value-equivalent to calc(1)
Fail tan(0.125turn) should be computed-value-equivalent to 1 Pass tan(0.125turn) should be computed-value-equivalent to 1
Fail tan(0.125turn) should be used-value-equivalent to 1 Pass tan(0.125turn) should be used-value-equivalent to 1
Fail calc(tan(0.125turn)) should be specified-value-equivalent to calc(1) Pass calc(tan(0.125turn)) should be specified-value-equivalent to calc(1)
Fail calc(tan(0.125turn)) should be computed-value-equivalent to 1 Pass calc(tan(0.125turn)) should be computed-value-equivalent to 1
Fail calc(tan(0.125turn)) should be used-value-equivalent to 1 Pass calc(tan(0.125turn)) should be used-value-equivalent to 1
Pass sin(180deg) should be specified-value-equivalent to calc(0) Pass sin(180deg) should be specified-value-equivalent to calc(0)
Pass sin(180deg) should be computed-value-equivalent to 0 Pass sin(180deg) should be computed-value-equivalent to 0
Pass sin(180deg) should be used-value-equivalent to 0 Pass sin(180deg) should be used-value-equivalent to 0