mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-23 09:22:30 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibIPC+Everywhere: Always pass ownership of transferred data to clients

Browse source 
This has been a longstanding ergonomic issue with our IPC compiler. Non-
trivial types were previously passed by const&. So if we wanted to avoid
expensive copies, we would have to const_cast and move the data.

We now pass ownership of all transferred data to the client subclasses.
This allows us to remove const_cast from these methods, and allows us to
avoid some trivial expensive copies that we didn't bother to const_cast.
This commit is contained in:
Timothy Flynn 2025-03-08 12:22:39 -05:00 • committed by Tim Flynn
parent 0f05aac290
commit cf69f52d53
Notes: github-actions[bot] 2025-03-09 15:15:22 +00:00
23 changed files with 395 additions and 399 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Services/WebDriver/WebContentConnection.cpp
View file

@ -20,10 +20,10 @@ void WebContentConnection::die()
on_close();
}
void WebContentConnection::driver_execution_complete(Web::WebDriver::Response const& response)
void WebContentConnection::driver_execution_complete(Web::WebDriver::Response response)
{
if (on_driver_execution_complete)
on_driver_execution_complete(response);
on_driver_execution_complete(move(response));
}
}