mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-22 02:09:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

AK: Make String::number() much faster for integer types
Some checks are pending
CI / Lagom (arm64, Sanitizer_CI, false, macos-15, macOS, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Fuzzers_CI, false, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, false, ubuntu-24.04, Linux, GNU) (push) Waiting to run
Details
CI / Lagom (x86_64, Sanitizer_CI, true, ubuntu-24.04, Linux, Clang) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (arm64, macos-15, macOS, macOS-universal2) (push) Waiting to run
Details
Package the js repl as a binary artifact / build-and-package (x86_64, ubuntu-24.04, Linux, Linux-x86_64) (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
Instead of going through String::formatted(), we now have a specialized
code path for base-10 serialization directly to UTF-8.

This is roughly 5-10x faster than the previous implementation, depending
on how many digits we end up outputting.

1.07x speedup on MicroBench/for-in-indexed-properties.js
This commit is contained in:
Andreas Kling 2025-05-02 13:12:14 +02:00 • committed by Andreas Kling
commit cf6e2531d9
Notes: github-actions[bot] 2025-05-02 17:13:56 +00:00
3 changed files with 99 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

42
Tests/AK/TestString.cpp
View file

@ -1561,3 +1561,45 @@ TEST_CASE(roman_numerals)
auto four_thousand = String::roman_number_from(4000, String::Case::Upper);
EXPECT_EQ(four_thousand, "4000"sv);
}
BENCHMARK_CASE(string_number_u16)
{
for (size_t i = 0; i < 10'000'000; ++i) {
(void)String::number(static_cast<u16>(12345));
}
}
BENCHMARK_CASE(string_number_u32)
{
for (size_t i = 0; i < 10'000'000; ++i) {
(void)String::number(static_cast<u32>(123456789));
}
}
BENCHMARK_CASE(string_number_u64)
{
for (size_t i = 0; i < 10'000'000; ++i) {
(void)String::number(static_cast<u64>(123456789));
}
}
BENCHMARK_CASE(string_number_i16)
{
for (size_t i = 0; i < 10'000'000; ++i) {
(void)String::number(static_cast<i16>(-12345));
}
}
BENCHMARK_CASE(string_number_i32)
{
for (size_t i = 0; i < 10'000'000; ++i) {
(void)String::number(static_cast<i32>(-123456789));
}
}
BENCHMARK_CASE(string_number_i64)
{
for (size_t i = 0; i < 10'000'000; ++i) {
(void)String::number(static_cast<i64>(-123456789));
}
}