mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-24 18:02:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Remove unused code in for_each_property_expanding_shorthands

Browse source 
This case is already handled by this point as `value` is a shorthand.

No functionality changes.
This commit is contained in:
Callum Law 2025-07-10 03:04:13 +12:00 • committed by Tim Ledbetter
parent ce79bc793c
commit cfafb3bf36
Notes: github-actions[bot] 2025-07-09 16:00:40 +00:00
2 changed files with 1 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibWeb/CSS/Parser/PropertyParsing.cpp
View file

@ -1647,6 +1647,7 @@ RefPtr<CSSStyleValue const> Parser::parse_border_value(PropertyID property_id, T
if (!border_color) if (!border_color)
border_color = property_initial_value(color_property); border_color = property_initial_value(color_property);
// FIXME: Also reset border-image, in line with the spec: https://www.w3.org/TR/css-backgrounds-3/#border-shorthands
transaction.commit(); transaction.commit();
return ShorthandStyleValue::create(property_id, return ShorthandStyleValue::create(property_id,
{ width_property, style_property, color_property }, { width_property, style_property, color_property },

9
Libraries/LibWeb/CSS/StyleComputer.cpp
View file

@ -681,15 +681,6 @@ void StyleComputer::for_each_property_expanding_shorthands(PropertyID property_i
} }
}; };
if (property_id == CSS::PropertyID::Border) {
for_each_property_expanding_shorthands(CSS::PropertyID::BorderTop, value, set_longhand_property);
for_each_property_expanding_shorthands(CSS::PropertyID::BorderRight, value, set_longhand_property);
for_each_property_expanding_shorthands(CSS::PropertyID::BorderBottom, value, set_longhand_property);
for_each_property_expanding_shorthands(CSS::PropertyID::BorderLeft, value, set_longhand_property);
// FIXME: Also reset border-image, in line with the spec: https://www.w3.org/TR/css-backgrounds-3/#border-shorthands
return;
}
if (property_id == CSS::PropertyID::BorderStyle) { if (property_id == CSS::PropertyID::BorderStyle) {
assign_edge_values(PropertyID::BorderTopStyle, PropertyID::BorderRightStyle, PropertyID::BorderBottomStyle, PropertyID::BorderLeftStyle, value); assign_edge_values(PropertyID::BorderTopStyle, PropertyID::BorderRightStyle, PropertyID::BorderBottomStyle, PropertyID::BorderLeftStyle, value);
return; return;