mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-08 02:26:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Remove unnecessary Document::force_layout() API

Browse source 
The only remaining client of this API can simply not call it, and let
normal DOM layout invalidation happen.
This commit is contained in:
Andreas Kling 2024-04-14 09:31:36 +02:00
commit d0076aaa24
Notes: sideshowbarker 2024-07-18 01:43:16 +09:00
3 changed files with 0 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/DOM/Document.cpp
View file

@ -1007,12 +1007,6 @@ void Document::set_needs_layout()
schedule_layout_update(); schedule_layout_update();
} }
void Document::force_layout()
{
tear_down_layout_tree();
update_layout();
}
void Document::invalidate_layout() void Document::invalidate_layout()
{ {
tear_down_layout_tree(); tear_down_layout_tree();

2
Userland/Libraries/LibWeb/DOM/Document.h
View file

@ -207,8 +207,6 @@ public:
Color visited_link_color() const; Color visited_link_color() const;
void set_visited_link_color(Color); void set_visited_link_color(Color);
void force_layout();
void update_style(); void update_style();
void update_layout(); void update_layout();
void update_paint_and_hit_testing_properties_if_needed(); void update_paint_and_hit_testing_properties_if_needed();

5
Userland/Services/WebContent/ConnectionFromClient.cpp
View file

@ -743,11 +743,6 @@ void ConnectionFromClient::remove_dom_node(u64 page_id, i32 node_id)
dom_node->remove(); dom_node->remove();
// FIXME: When nodes are removed from the DOM, the associated layout nodes become stale and still
// remain in the layout tree. This has to be fixed, this just causes everything to be recomputed
// which really hurts performance.
active_document->force_layout();
async_did_finish_editing_dom_node(page_id, previous_dom_node->unique_id()); async_did_finish_editing_dom_node(page_id, previous_dom_node->unique_id());
} }