mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-31 21:29:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/HTML: Update spec comments for location hash setter

Browse source 
Corresponds to open merge request in HTML spec of whatwg/html#11245
and a WPT test change of web-platform-tests/wpt#52085.
This commit is contained in:
Shannon Booth 2025-04-22 19:18:24 +12:00 • committed by Tim Ledbetter
commit d01ee20b67
Notes: github-actions[bot] 2025-04-23 07:25:35 +00:00
3 changed files with 32 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Libraries/LibWeb/HTML/Location.cpp
View file

@ -500,23 +500,23 @@ WebIDL::ExceptionOr<void> Location::set_hash(String const& value)
// 3. Let copyURL be a copy of this's url.
auto copy_url = this->url();
// 4. Let input be the given value with a single leading "#" removed, if any.
// 4. Let thisURLFragment be copyURL's fragment if it is non-null; otherwise the empty string.
auto this_url_fragment = copy_url.fragment().has_value() ? *copy_url.fragment() : String {};
// 5. Let input be the given value with a single leading "#" removed, if any.
auto input = value.bytes_as_string_view().trim("#"sv, TrimMode::Left);
// 5. Set copyURL's fragment to the empty string.
// 6. Set copyURL's fragment to the empty string.
copy_url.set_fragment(String {});
// 6. Basic URL parse input, with copyURL as url and fragment state as state override.
// 7. Basic URL parse input, with copyURL as url and fragment state as state override.
(void)URL::Parser::basic_parse(input, {}, &copy_url, URL::Parser::State::Fragment);
// 7. If copyURL's fragment is this's url's fragment, then return.
// NOTE: Ignore null values when comparing fragments. This behavior is not explicitly mentioned in the specs, potential bug?
auto copy_url_fragment = copy_url.fragment().has_value() ? copy_url.fragment() : String {};
auto this_url_fragment = this->url().fragment().has_value() ? this->url().fragment() : String {};
if (copy_url_fragment == this_url_fragment)
// 8. If copyURL's fragment is thisURLFragment, then return.
if (copy_url.fragment() == this_url_fragment)
return {};
// 8. Location-object navigate this to copyURL.
// 9. Location-object navigate this to copyURL.
TRY(navigate(copy_url));
return {};

6
Tests/LibWeb/Text/expected/wpt-import/html/browsers/history/the-location-interface/location_hash_set_empty_string.txt Normal file
View file

@ -0,0 +1,6 @@
Harness status: OK
Found 1 tests
1 Pass
Pass window.location.hash is an empty string

17
Tests/LibWeb/Text/input/wpt-import/html/browsers/history/the-location-interface/location_hash_set_empty_string.html Normal file
View file

@ -0,0 +1,17 @@
<!doctype html>
<meta charset="utf-8">
<title>Set window.location.hash to an empty string</title>
<link rel="author" href="mailto:cristianb@gmail.com">
<link rel="help" href="https://html.spec.whatwg.org/multipage/#dom-location-hash">
<script src="../../../../resources/testharness.js"></script>
<script src="../../../../resources/testharnessreport.js"></script>
<script>
const orig_location = window.location.href;
window.location.hash = '';
test(() => {
assert_true(window.location.hash === '');
assert_true(window.location.href === orig_location);
}, 'window.location.hash is an empty string');
</script>