mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-31 13:19:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Preserve unit when serializing time values

Browse source 
Previously, when serializing a time value, we would always convert it
to seconds. We now canonicalize the time value only when serializing
its computed value.
This commit is contained in:
Tim Ledbetter 2025-03-19 16:48:33 +00:00 • committed by Sam Atkins
commit d0be5a0cdf
Notes: github-actions[bot] 2025-03-20 17:00:33 +00:00
4 changed files with 35 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibWeb/CSS/StyleValues/TimeStyleValue.h
View file

@ -26,7 +26,12 @@ public:
virtual double value() const override { return m_time.raw_value(); }
virtual StringView unit() const override { return m_time.unit_name(); }
virtual String to_string(SerializationMode) const override { return m_time.to_string(); }
virtual String to_string(SerializationMode serialization_mode) const override
{
if (serialization_mode == SerializationMode::ResolvedValue)
return MUST(String::formatted("{}s", m_time.to_seconds()));
return m_time.to_string();
}
bool equals(CSSStyleValue const& other) const override
{