mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-04 23:30:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Demote some overly paranoid VERIFY()s in ESFO [[Call]] flow

Browse source
This commit is contained in:
Andreas Kling 2025-04-28 01:53:44 +02:00 • committed by Andreas Kling
commit d0d87d3aed
Notes: github-actions[bot] 2025-04-28 10:46:07 +00:00
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibJS/Runtime/ECMAScriptFunctionObject.cpp
View file

@ -503,7 +503,7 @@ ThrowCompletionOr<Value> ECMAScriptFunctionObject::internal_call(ExecutionContex
{ {
auto& vm = this->vm(); auto& vm = this->vm();
VERIFY(m_bytecode_executable); ASSERT(m_bytecode_executable);
// 1. Let callerContext be the running execution context. // 1. Let callerContext be the running execution context.
// NOTE: No-op, kept by the VM in its execution context stack. // NOTE: No-op, kept by the VM in its execution context stack.
@ -513,7 +513,7 @@ ThrowCompletionOr<Value> ECMAScriptFunctionObject::internal_call(ExecutionContex
TRY(prepare_for_ordinary_call(vm, callee_context, nullptr)); TRY(prepare_for_ordinary_call(vm, callee_context, nullptr));
// 3. Assert: calleeContext is now the running execution context. // 3. Assert: calleeContext is now the running execution context.
VERIFY(&vm.running_execution_context() == &callee_context); ASSERT(&vm.running_execution_context() == &callee_context);
// 4. If F.[[IsClassConstructor]] is true, then // 4. If F.[[IsClassConstructor]] is true, then
if (is_class_constructor()) { if (is_class_constructor()) {
@ -543,7 +543,7 @@ ThrowCompletionOr<Value> ECMAScriptFunctionObject::internal_call(ExecutionContex
return result.value(); return result.value();
// 9. Assert: result is a throw completion. // 9. Assert: result is a throw completion.
VERIFY(result.type() == Completion::Type::Throw); ASSERT(result.type() == Completion::Type::Throw);
// 10. Return ? result. // 10. Return ? result.
return result.release_error(); return result.release_error();