mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-20 16:28:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

LibWeb/Geometry: Correct typos in DOMMatrix "not 0 or -0" checks
Some checks are pending
CI / macOS, arm64, Sanitizer, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Fuzzers, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer, GNU (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer, Clang (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
Assuming 0 and -0 are distinct values, `a != 0 || a != -0` is always
true.
This commit is contained in:
Sam Atkins 2025-09-15 12:15:57 +01:00 • committed by Jelle Raaijmakers
commit d127eb5117
Notes: github-actions[bot] 2025-09-15 11:35:26 +00:00
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/Geometry/DOMMatrix.cpp
View file

@ -423,7 +423,7 @@ GC::Ref<DOMMatrix> DOMMatrix::translate_self(Optional<double> tx, Optional<doubl
m_matrix = m_matrix * Gfx::translation_matrix(Vector3<double> { tx.value_or(0), ty.value_or(0), tz.value_or(0) });
// 2. If tz is specified and not 0 or -0, set is 2D of the current matrix to false.
if (tz.has_value() && (tz != 0 || tz != -0))
if (tz.has_value() && (tz != 0 && tz != -0))
m_is_2d = false;
// 3. Return the current matrix.
@ -494,7 +494,7 @@ GC::Ref<DOMMatrix> DOMMatrix::rotate_self(Optional<double> rot_x, Optional<doubl
rot_z = 0;
// 4. If rotX or rotY are not 0 or -0, set is 2D of the current matrix to false.
if (rot_x != 0 || rot_x != -0 || rot_y != 0 || rot_y != -0)
if ((rot_x != 0 && rot_x != -0) || (rot_y != 0 && rot_y != -0))
m_is_2d = false;
// 5. Post-multiply a rotation transformation on the current matrix around the vector 0, 0, 1 by the specified rotation rotZ in degrees. The 3D rotation matrix is described in CSS Transforms with alpha = rotZ in degrees. [CSS3-TRANSFORMS]
@ -529,7 +529,7 @@ GC::Ref<DOMMatrix> DOMMatrix::rotate_axis_angle_self(Optional<double> x, Optiona
m_matrix = m_matrix * Gfx::rotation_matrix<double>(Vector3<double> { x.value_or(0), y.value_or(0), z.value_or(0) }.normalized(), AK::to_radians(angle.value()));
// 2. If x or y are not 0 or -0, set is 2D of the current matrix to false.
if (x != 0 || x != -0 || y != 0 || y != -0)
if ((x != 0 && x != -0) || (y != 0 && y != -0))
m_is_2d = false;
// 3. Return the current matrix.