mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-11 21:52:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

AK+Meta: Update simdutf to version 5.5.0

Browse source 
Contains many fixes found upstream by fuzzers. Also includes fixes for
CPU-specific inconsistencies with null inputs.
This commit is contained in:
Timothy Flynn 2024-09-19 14:25:38 -04:00 • committed by Tim Flynn
parent ee060ed206
commit d19b31529f
Notes: github-actions[bot] 2024-09-19 19:49:50 +00:00
3 changed files with 1 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

10
AK/Utf8View.cpp
View file

@ -74,10 +74,6 @@ Utf8View Utf8View::unicode_substring_view(size_t code_point_offset, size_t code_
size_t Utf8View::calculate_length() const
{
// FIXME: The CPU-specific implementations behave differently on null inputs. We treat null views as an empty string.
if (is_empty())
return 0;
// FIXME: simdutf's code point length method assumes valid UTF-8, whereas Utf8View uses U+FFFD as a replacement
// for invalid code points. If we change Utf8View to only accept valid encodings as an invariant, we can
// remove this branch.
@ -157,12 +153,6 @@ Utf8View Utf8View::trim(Utf8View const& characters, TrimMode mode) const
bool Utf8View::validate(size_t& valid_bytes, AllowSurrogates allow_surrogates) const
{
// FIXME: The CPU-specific implementations behave differently on null inputs. We treat null views as an empty string.
if (is_empty()) {
valid_bytes = 0;
return true;
}
auto result = simdutf::validate_utf8_with_errors(m_string.characters_without_null_termination(), m_string.length());
valid_bytes = result.count;