mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibProtocol: Exit fatally if the connection to RequestServer disappears

Browse source 
The default implementation of die() causes the client process to simply
exit cleanly. This prevents any tests from recognizing that something
went wrong, as the process exits with a code of 0. With this patch, we
still just exit when the connection dies, but with a fatal signal. In
the future, we will want to launch a new RequestServer process and
re-establish client connections.
This commit is contained in:
Timothy Flynn 2024-06-06 07:16:14 -04:00 • committed by Andreas Kling
commit d1ec32e28f
Notes: sideshowbarker 2024-07-17 01:00:06 +09:00
2 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibProtocol/RequestClient.cpp
View file

@ -14,6 +14,13 @@ RequestClient::RequestClient(NonnullOwnPtr<Core::LocalSocket> socket)
{
}
void RequestClient::die()
{
// FIXME: Gracefully handle this, or relaunch and reconnect to RequestServer.
warnln("\033[31;1mLost connection to RequestServer\033[0m");
VERIFY_NOT_REACHED();
}
void RequestClient::ensure_connection(URL::URL const& url, ::RequestServer::CacheLevel cache_level)
{
async_ensure_connection(url, cache_level);