mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-04 00:27:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Handle border-{inline,block}-* properties with a single value

Browse source 
Gains us 14 WPT tests
This commit is contained in:
Callum Law 2025-07-09 19:42:07 +12:00 • committed by Sam Atkins
commit d280cf56e6
Notes: github-actions[bot] 2025-07-09 09:12:10 +00:00
6 changed files with 82 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

34
Libraries/LibWeb/CSS/Properties.json
View file

@ -503,6 +503,10 @@
"longhands": [
"border-block-start-color",
"border-block-end-color"
],
"max-values": 2,
"valid-types": [
"color"
]
},
"border-block-end": {
@ -571,6 +575,10 @@
"longhands": [
"border-block-start-style",
"border-block-end-style"
],
"max-values": 2,
"valid-types": [
"line-style"
]
},
"border-block-width": {
@ -579,6 +587,15 @@
"longhands": [
"border-block-start-width",
"border-block-end-width"
],
"max-values": 2,
"valid-types": [
"length [0,∞]"
],
"valid-identifiers": [
"medium",
"thick",
"thin"
]
},
"border-bottom": {
@ -767,6 +784,10 @@
"longhands": [
"border-inline-start-color",
"border-inline-end-color"
],
"max-values": 2,
"valid-types": [
"color"
]
},
"border-inline-end": {
@ -835,6 +856,10 @@
"longhands": [
"border-inline-start-style",
"border-inline-end-style"
],
"max-values": 2,
"valid-types": [
"line-style"
]
},
"border-inline-width": {
@ -843,6 +868,15 @@
"longhands": [
"border-inline-start-width",
"border-inline-end-width"
],
"max-values": 2,
"valid-types": [
"length [0,∞]"
],
"valid-identifiers": [
"medium",
"thick",
"thin"
]
},
"border-left": {

30
Libraries/LibWeb/CSS/StyleComputer.cpp
View file

@ -693,16 +693,46 @@ void StyleComputer::for_each_property_expanding_shorthands(PropertyID property_i
return;
}
if (property_id == CSS::PropertyID::BorderBlockStyle) {
assign_start_and_end_values(PropertyID::BorderBlockStartStyle, PropertyID::BorderBlockEndStyle, value);
return;
}
if (property_id == CSS::PropertyID::BorderInlineStyle) {
assign_start_and_end_values(PropertyID::BorderInlineStartStyle, PropertyID::BorderInlineEndStyle, value);
return;
}
if (property_id == CSS::PropertyID::BorderWidth) {
assign_edge_values(PropertyID::BorderTopWidth, PropertyID::BorderRightWidth, PropertyID::BorderBottomWidth, PropertyID::BorderLeftWidth, value);
return;
}
if (property_id == CSS::PropertyID::BorderBlockWidth) {
assign_start_and_end_values(PropertyID::BorderBlockStartWidth, PropertyID::BorderBlockEndWidth, value);
return;
}
if (property_id == CSS::PropertyID::BorderInlineWidth) {
assign_start_and_end_values(PropertyID::BorderInlineStartWidth, PropertyID::BorderInlineEndWidth, value);
return;
}
if (property_id == CSS::PropertyID::BorderColor) {
assign_edge_values(PropertyID::BorderTopColor, PropertyID::BorderRightColor, PropertyID::BorderBottomColor, PropertyID::BorderLeftColor, value);
return;
}
if (property_id == CSS::PropertyID::BorderBlockColor) {
assign_start_and_end_values(PropertyID::BorderBlockStartColor, PropertyID::BorderBlockEndColor, value);
return;
}
if (property_id == CSS::PropertyID::BorderInlineColor) {
assign_start_and_end_values(PropertyID::BorderInlineStartColor, PropertyID::BorderInlineEndColor, value);
return;
}
if (property_id == CSS::PropertyID::BackgroundPosition) {
if (value.is_position()) {
auto const& position = value.as_position();