mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-22 02:09:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't make flex layout responsible for flex container cross size

Browse source 
Although the flex algorithm as specified does say to determine the cross
size of the flex container, this is not how our layout engine works.

The parent formatting context is responsible for sizing its children,
and since that's already happening, we can simply remove the cross
sizing step from FFC.
This commit is contained in:
Andreas Kling 2024-03-26 20:17:07 +01:00
commit d37c0a2cab
Notes: sideshowbarker 2024-07-16 22:18:54 +09:00
6 changed files with 36 additions and 54 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Layout/FlexFormattingContext.h
View file

@ -191,8 +191,6 @@ private:
void align_all_flex_items_along_the_cross_axis();
void determine_flex_container_used_cross_size();
void align_all_flex_lines();
bool is_row_layout() const { return m_flex_direction == CSS::FlexDirection::Row || m_flex_direction == CSS::FlexDirection::RowReverse; }