mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-20 16:28:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

LibWeb/SVG: Ignore view boxes with negative width or height

Browse source
This commit is contained in:
Tim Ledbetter 2025-07-12 14:35:48 +01:00 • committed by Andreas Kling
commit d38fac7518
Notes: github-actions[bot] 2025-07-21 22:53:29 +00:00
4 changed files with 17 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/SVG/ViewBox.cpp
View file

@ -41,9 +41,13 @@ Optional<ViewBox> try_parse_view_box(StringView string)
view_box.min_y = maybe_number.value();
break;
case State::Width:
if (*maybe_number < 0)
return {};
view_box.width = maybe_number.value();
break;
case State::Height:
if (*maybe_number < 0)
return {};
view_box.height = maybe_number.value();
break;
default:

2
Tests/LibWeb/Ref/expected/wpt-import/svg/struct/reftests/reference/green-100x100.html Normal file
View file

@ -0,0 +1,2 @@
<!DOCTYPE html>
<div style="width: 100px; height: 100px; background-color: green"></div>

5
Tests/LibWeb/Ref/input/wpt-import/svg/coordinate-systems/support/views.svg Normal file
View file

@ -0,0 +1,5 @@
<svg xmlns="http://www.w3.org/2000/svg" width="100" viewBox="0 0 100 100">
<view id="transform" viewBox="-100 -100 200 200"/>
<view id="invalid" viewBox="0 0 -100 200"/>
<rect width="100" height="100" fill="green"/>
</svg>
Side by side

After

Width:  |  Height:  |  Size: 229 B

6
Tests/LibWeb/Ref/input/wpt-import/svg/coordinate-systems/view-invalid-viewBox.html Normal file
View file

@ -0,0 +1,6 @@
<!doctype HTML>
<title>view element with invalid viewBox should be ignored</title>
<link rel="help" href="https://svgwg.org/svg2-draft/linking.html#ViewElement">
<link rel="match" href="../../../../expected/wpt-import/svg/coordinate-systems/../struct/reftests/reference/green-100x100.html">
<img src="support/views.svg#invalid">