mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-20 19:45:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Ensure inert elements are not selectable

Browse source
This commit is contained in:
Tim Ledbetter 2025-02-05 23:41:40 +00:00 • committed by Sam Atkins
parent cb405c773b
commit d410fa8381
Notes: github-actions[bot] 2025-02-21 12:43:13 +00:00
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibWeb/Painting/ViewportPaintable.cpp
View file

@ -298,7 +298,7 @@ void ViewportPaintable::recompute_selection_states(DOM::Range& range)
}
// 2. If it's a text node, mark it as StartAndEnd and return.
if (is<DOM::Text>(*start_container)) {
if (is<DOM::Text>(*start_container) && !range.start().node->is_inert()) {
if (auto* paintable = start_container->paintable())
paintable->set_selection_state(SelectionState::StartAndEnd);
return;
@ -306,7 +306,7 @@ void ViewportPaintable::recompute_selection_states(DOM::Range& range)
}
// 3. Mark the selection start node as Start (if text) or Full (if anything else).
if (auto* paintable = start_container->paintable()) {
if (auto* paintable = start_container->paintable(); paintable && !range.start().node->is_inert()) {
if (is<DOM::Text>(*start_container))
paintable->set_selection_state(SelectionState::Start);
else
@ -314,12 +314,13 @@ void ViewportPaintable::recompute_selection_states(DOM::Range& range)
}
// 4. Mark the selection end node as End (if text) or Full (if anything else).
if (auto* paintable = end_container->paintable()) {
if (auto* paintable = end_container->paintable(); paintable && !range.end().node->is_inert()) {
if (is<DOM::Text>(*end_container) || end_container->is_ancestor_of(start_container)) {
paintable->set_selection_state(SelectionState::End);
} else {
paintable->for_each_in_inclusive_subtree([&](auto& layout_node) {
layout_node.set_selection_state(SelectionState::Full);
if (!layout_node.dom_node() || !layout_node.dom_node()->is_inert())
layout_node.set_selection_state(SelectionState::Full);
return TraversalDecision::Continue;
});
}
@ -327,6 +328,8 @@ void ViewportPaintable::recompute_selection_states(DOM::Range& range)
// 5. Mark the nodes between start node and end node (in tree order) as Full.
for (auto* node = start_container->next_in_pre_order(); node && (node->is_before(end_container) || node->is_descendant_of(end_container)); node = node->next_in_pre_order()) {
if (node->is_inert())
continue;
if (auto* paintable = node->paintable())
paintable->set_selection_state(SelectionState::Full);
}