From d49fb169bc6dd33c7ffa2832bfdea97a61e86161 Mon Sep 17 00:00:00 2001 From: CountBleck Date: Wed, 13 Aug 2025 21:52:55 -0700 Subject: [PATCH] LibWeb: Correct typos for user validity of form elements on submission The spec and comments say "set field's user validity to true", but we now actually set it to true and not false. This passes one subtest in WPT's css/selectors/user-valid.html. --- Libraries/LibWeb/HTML/HTMLFormElement.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Libraries/LibWeb/HTML/HTMLFormElement.cpp b/Libraries/LibWeb/HTML/HTMLFormElement.cpp index 7e02ca2f4aa..940831f0ba2 100644 --- a/Libraries/LibWeb/HTML/HTMLFormElement.cpp +++ b/Libraries/LibWeb/HTML/HTMLFormElement.cpp @@ -131,11 +131,11 @@ WebIDL::ExceptionOr HTMLFormElement::submit_form(GC::Ref subm // NOTE: Only input, select and textarea elements have a user validity flag. // See https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#user-validity if (is(*element)) { - (&as(*element))->set_user_validity(false); + (&as(*element))->set_user_validity(true); } else if (is(*element)) { - (&as(*element))->set_user_validity(false); + (&as(*element))->set_user_validity(true); } else if (is(*element)) { - (&as(*element))->set_user_validity(false); + (&as(*element))->set_user_validity(true); } }