From d5bbf8dcf803c429afab76610dfba3b1ee23f0ae Mon Sep 17 00:00:00 2001
From: Andreas Kling <andreas@ladybird.org>
Date: Mon, 23 Dec 2024 15:24:09 +0100
Subject: [PATCH] LibWeb: Do lighter style invalidation for `style` attribute
 changes

When the `style` attribute changes, we only need to update style on the
element itself (unless there are [style] attribute selectors somewhere).

Descendants of the element don't need a full style update, a simple
inheritance propagation is enough.
---
 Libraries/LibWeb/DOM/Element.cpp | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/Libraries/LibWeb/DOM/Element.cpp b/Libraries/LibWeb/DOM/Element.cpp
index 132f3b7f9dc..2569f340f68 100644
--- a/Libraries/LibWeb/DOM/Element.cpp
+++ b/Libraries/LibWeb/DOM/Element.cpp
@@ -1902,7 +1902,21 @@ ErrorOr<void> Element::scroll_into_view(Optional<Variant<bool, ScrollIntoViewOpt
 void Element::invalidate_style_after_attribute_change(FlyString const& attribute_name)
 {
     // FIXME: Only invalidate if the attribute can actually affect style.
-    (void)attribute_name;
+
+    // OPTIMIZATION: For the `style` attribute, unless it's referenced by an attribute selector,
+    //               only invalidate the element itself, then let inheritance propagate to descendants.
+    if (attribute_name == HTML::AttributeNames::style
+        && !document().style_computer().has_attribute_selector(HTML::AttributeNames::style)) {
+        set_needs_style_update(true);
+        for_each_shadow_including_descendant([](Node& node) {
+            if (!node.is_element())
+                return TraversalDecision::Continue;
+            auto& element = static_cast<Element&>(node);
+            element.set_needs_inherited_style_update(true);
+            return TraversalDecision::Continue;
+        });
+        return;
+    }
 
     invalidate_style(StyleInvalidationReason::ElementAttributeChange);
 }