mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-25 10:48:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Change Element::closest() to check if any of selector matches

Browse source 
...instead of checking if all selectors match an element.

Fixes bug reduced from GitHub's "new issue" page.
This commit is contained in:
Aliaksandr Kalenik 2024-03-22 17:53:58 +01:00 • committed by Andreas Kling
commit d5c6e45dca
Notes: sideshowbarker 2024-07-17 06:40:21 +09:00
3 changed files with 15 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/DOM/Element-closest.txt Normal file
View file

@ -0,0 +1 @@
<DIV id="target" >

10
Tests/LibWeb/Text/input/DOM/Element-closest.html Normal file
View file

@ -0,0 +1,10 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<div class="a" id="target"><div id="nested"></div></div>
<script>
test(() => {
const matchingElement = document.getElementById("nested").closest(".a, .b, .c");
printElement(matchingElement);
});
</script>
</html>

8
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -678,11 +678,11 @@ WebIDL::ExceptionOr<DOM::Element const*> Element::closest(StringView selectors)
auto matches_selectors = [this](CSS::SelectorList const& selector_list, Element const* element) { auto matches_selectors = [this](CSS::SelectorList const& selector_list, Element const* element) {
// 4. For each element in elements, if match a selector against an element, using s, element, and scoping root this, returns success, return element. // 4. For each element in elements, if match a selector against an element, using s, element, and scoping root this, returns success, return element.
for (auto& selector : selector_list) { for (auto const& selector : selector_list) {
if (!SelectorEngine::matches(selector, {}, *element, {}, this)) if (SelectorEngine::matches(selector, {}, *element, {}, this))
return false;
}
return true; return true;
}
return false;
}; };
auto const selector_list = maybe_selectors.release_value(); auto const selector_list = maybe_selectors.release_value();