mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-30 05:09:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Unset stylesheet properties when removing from a StyleSheetList

Browse source 
Previously, the parent CSS stylesheet, owner node and owner CSS rule
properties were not unset when removing a sheet from a StyleSheetList.

This change moves the methods for adding and removing sheets to and
from a StyleSheetList, directly into the StyleSheetList class and
ensures they are called as required by the CSSOM specification.
This commit is contained in:
Tim Ledbetter 2024-04-15 21:42:46 +01:00 • committed by Andreas Kling
commit d5cddd4696
Notes: sideshowbarker 2024-07-17 06:40:21 +09:00
7 changed files with 78 additions and 66 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/CSS/StyleSheetList.h
View file

@ -19,8 +19,9 @@ class StyleSheetList final : public Bindings::PlatformObject {
public:
[[nodiscard]] static JS::NonnullGCPtr<StyleSheetList> create(DOM::Document&);
void add_sheet(CSSStyleSheet&);
void remove_sheet(CSSStyleSheet&);
void add_a_css_style_sheet(CSS::CSSStyleSheet&);
void remove_a_css_style_sheet(CSS::CSSStyleSheet&);
void create_a_css_style_sheet(String type, DOM::Element* owner_node, String media, String title, bool alternate, bool origin_clean, Optional<String> location, CSS::CSSStyleSheet* parent_style_sheet, CSS::CSSRule* owner_rule, CSS::CSSStyleSheet&);
Vector<JS::NonnullGCPtr<CSSStyleSheet>> const& sheets() const { return m_sheets; }
Vector<JS::NonnullGCPtr<CSSStyleSheet>>& sheets() { return m_sheets; }
@ -46,6 +47,9 @@ private:
virtual void initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
void add_sheet(CSSStyleSheet&);
void remove_sheet(CSSStyleSheet&);
void sort_sheets();
JS::NonnullGCPtr<DOM::Document> m_document;