LibJS+LibWeb: Remove NonnullGCPtr<T>::operator=(GCPtr<T>) footgun

GCPtr can be null so it's not safe to assign it to a NonnullGCPtr unless you know it to be non-null. This exposed a number of wrong uses in LibWeb which had to be fixed as part of this change.
Author: https://github.com/awesomekling Commit: d5ed07fdc4 Pull-request: https://github.com/SerenityOS/serenity/pull/16489 Reviewed-by: https://github.com/linusg ✅
2025-09-10 11:36:22 +00:00 · 2022-12-14 13:43:57 +01:00 · 2022-12-14 13:43:57 +01:00 · d5ed07fdc4 · 2024-07-17 06:40:21 +09:00
commit d5ed07fdc4
parent 4abdb68655
5 changed files with 32 additions and 39 deletions
--- a/Userland/Libraries/LibJS/Heap/GCPtr.h
+++ b/Userland/Libraries/LibJS/Heap/GCPtr.h
@ -49,13 +49,6 @@ public:
    {
    }

-    NonnullGCPtr& operator=(GCPtr<T> const& other)
-    {
-        m_ptr = const_cast<T*>(other.ptr());
-        VERIFY(m_ptr);
-        return *this;
-    }
-
    NonnullGCPtr& operator=(T const& other)
    {
        m_ptr = &const_cast<T&>(other);