mirrors/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-20 11:36:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Limit usage of getElementById() cache to connected roots

Browse source 
Fixes bug when we always return null from getElementById() on
unconnected roots because id to element cache is only maintained for
connected roots.

Fixes broken Perf-Dashboard suite in Speedometer 3.
This commit is contained in:
Aliaksandr Kalenik 2025-04-06 02:28:18 +02:00 • committed by Alexander Kalenik
parent 3c2a2bb39f
commit d5edd62e57
Notes: github-actions[bot] 2025-04-06 02:15:27 +00:00
3 changed files with 24 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
Libraries/LibWeb/DOM/ParentNode.cpp
View file

@ -262,14 +262,16 @@ GC::Ref<HTMLCollection> ParentNode::get_elements_by_class_name(StringView class_
GC::Ptr<Element> ParentNode::get_element_by_id(FlyString const& id) const
{
// For document and shadow root we have a cache that allows fast lookup.
if (is_document()) {
auto const& document = static_cast<Document const&>(*this);
return document.element_by_id().get(id);
}
if (is_shadow_root()) {
auto const& shadow_root = static_cast<ShadowRoot const&>(*this);
return shadow_root.element_by_id().get(id);
if (is_connected()) {
// For connected document and shadow root we have a cache that allows fast lookup.
if (is_document()) {
auto const& document = static_cast<Document const&>(*this);
return document.element_by_id().get(id);
}
if (is_shadow_root()) {
auto const& shadow_root = static_cast<ShadowRoot const&>(*this);
return shadow_root.element_by_id().get(id);
}
}
GC::Ptr<Element> found_element;

1
Tests/LibWeb/Text/expected/DOM/getElementById-on-unconnected-shadow-tree.txt Normal file
View file

@ -0,0 +1 @@
HelloWorld

13
Tests/LibWeb/Text/input/DOM/getElementById-on-unconnected-shadow-tree.html Normal file
View file

@ -0,0 +1,13 @@
<!DOCTYPE html>
<body></body>
<script src="../include.js"></script>
<script>
test(() => {
let host = document.createElement("div");
let shadow = host.attachShadow({ mode: "open" });
shadow.innerHTML = `<p id="foo">Hello</p><span id="bar">World</span>`;
let foo = shadow.getElementById("foo");
let bar = shadow.getElementById("bar");
println(foo.textContent + bar.textContent);
});
</script>