mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-10-19 06:29:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Separate relative sizes from absolute_size_mapping

Browse source 
Having relative sizes handled in this function was misleading
This commit is contained in:
Callum Law 2025-08-29 17:52:45 +12:00 • committed by Sam Atkins
commit d6754307f9
Notes: github-actions[bot] 2025-09-19 09:09:15 +00:00
5 changed files with 88 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Libraries/LibWeb/Editing/Internal/Algorithms.cpp
View file

@ -4613,8 +4613,15 @@ CSSPixels font_size_to_pixel_size(Utf16View const& font_size)
if (!keyword.has_value())
return pixel_size;
// Convert the keyword to an absolute-size
auto absolute_size = CSS::keyword_to_absolute_size(keyword.value());
// If that failed - give up
if (!absolute_size.has_value())
return pixel_size;
// Return scaled pixel size
return pixel_size * CSS::StyleComputer::absolute_size_mapping(keyword.release_value());
return CSS::StyleComputer::absolute_size_mapping(absolute_size.value(), pixel_size);
}
void for_each_node_effectively_contained_in_range(GC::Ptr<DOM::Range> range, Function<TraversalDecision(GC::Ref<DOM::Node>)> callback)