mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-09 12:42:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibGUI: Suggest classes when typing identifiers

Browse source 
We now suggest classes even if the line does not start with an @.
After all, we now have fuzzy matching, so why *shouldn't* "color"
match @GUI::ColorInput as well as background_color?
This commit is contained in:
thislooksfun 2021-10-27 19:39:10 -05:00 • committed by Andreas Kling
parent 22a955b2d7
commit d73d044f2b
Notes: sideshowbarker 2024-07-18 01:34:54 +09:00
1 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Userland/Libraries/LibGUI/GMLAutocompleteProvider.cpp
View file

@ -184,15 +184,24 @@ void GMLAutocompleteProvider::provide_completions(Function<void(Vector<Entry>)>
break; break;
} }
case InIdentifier: { case InIdentifier: {
if (class_names.is_empty())
break;
if (last_seen_token && last_seen_token->m_end.column != cursor.column() && last_seen_token->m_end.line == cursor.line()) { if (last_seen_token && last_seen_token->m_end.column != cursor.column() && last_seen_token->m_end.line == cursor.line()) {
// After an identifier, but with extra space // After an identifier, but with extra space
// TODO: Maybe suggest a colon? // TODO: Maybe suggest a colon?
break; break;
} }
register_class_properties_matching_pattern(make_fuzzy(identifier_string), identifier_string.length()); auto fuzzy_pattern = make_fuzzy(identifier_string);
if (!class_names.is_empty()) {
register_class_properties_matching_pattern(fuzzy_pattern, identifier_string.length());
auto parent_registration = Core::ObjectClassRegistration::find(class_names.last());
if (parent_registration && parent_registration->is_derived_from(layout_class)) {
// Layouts can't have child classes, so why suggest them?
break;
}
}
register_widgets_matching_pattern(fuzzy_pattern, identifier_string.length());
break; break;
} }
case AfterClassName: { case AfterClassName: {