mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-07 00:29:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't serialize scale z value if it is 1

Browse source
This commit is contained in:
Tim Ledbetter 2025-04-29 16:58:41 +01:00 • committed by Andreas Kling
commit d804f1311c
Notes: github-actions[bot] 2025-04-30 17:38:02 +00:00
3 changed files with 15 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/CSS/StyleValues/TransformationStyleValue.cpp
View file

@ -130,7 +130,7 @@ String TransformationStyleValue::to_string(SerializationMode mode) const
auto x_value = resolve_to_string(m_properties.values[0]);
auto y_value = resolve_to_string(m_properties.values[1]);
Optional<String> z_value;
if (m_properties.values.size() == 3)
if (m_properties.values.size() == 3 && (!m_properties.values[2]->is_number() || m_properties.values[2]->as_number().number() != 1))
z_value = resolve_to_string(m_properties.values[2]);
StringBuilder builder;

15
Tests/LibWeb/Text/expected/wpt-import/css/css-transforms/parsing/scale-parsing-computed.txt
View file

@ -2,8 +2,7 @@ Harness status: OK
Found 22 tests
16 Pass
6 Fail
22 Pass
Pass Property scale value 'none'
Pass Property scale value '1'
Pass Property scale value '1%'
@ -11,18 +10,18 @@ Pass Property scale value '100'
Pass Property scale value '100%'
Pass Property scale value '100 100'
Pass Property scale value '100% 100%'
Fail Property scale value '100 100 1'
Fail Property scale value '100% 100% 1'
Pass Property scale value '100 100 1'
Pass Property scale value '100% 100% 1'
Pass Property scale value '-100'
Pass Property scale value '-100%'
Pass Property scale value '-100 -100'
Pass Property scale value '-100% -100%'
Fail Property scale value '-100 -100 1'
Fail Property scale value '-100% -100% 1'
Pass Property scale value '-100 -100 1'
Pass Property scale value '-100% -100% 1'
Pass Property scale value '100 200'
Pass Property scale value '100% 200%'
Fail Property scale value '100 200 1'
Fail Property scale value '100% 200% 1'
Pass Property scale value '100 200 1'
Pass Property scale value '100% 200% 1'
Pass Property scale value '100 200 300'
Pass Property scale value '100 100 2'
Pass Property scale value '100% 200% 300%'

15
Tests/LibWeb/Text/expected/wpt-import/css/css-transforms/parsing/scale-parsing-valid.txt
View file

@ -2,8 +2,7 @@ Harness status: OK
Found 22 tests
16 Pass
6 Fail
22 Pass
Pass e.style['scale'] = "none" should set the property value
Pass e.style['scale'] = "1" should set the property value
Pass e.style['scale'] = "1%" should set the property value
@ -11,18 +10,18 @@ Pass e.style['scale'] = "100" should set the property value
Pass e.style['scale'] = "100%" should set the property value
Pass e.style['scale'] = "100 100" should set the property value
Pass e.style['scale'] = "100% 100%" should set the property value
Fail e.style['scale'] = "100 100 1" should set the property value
Fail e.style['scale'] = "100% 100% 1" should set the property value
Pass e.style['scale'] = "100 100 1" should set the property value
Pass e.style['scale'] = "100% 100% 1" should set the property value
Pass e.style['scale'] = "-100" should set the property value
Pass e.style['scale'] = "-100%" should set the property value
Pass e.style['scale'] = "-100 -100" should set the property value
Pass e.style['scale'] = "-100% -100%" should set the property value
Fail e.style['scale'] = "-100 -100 1" should set the property value
Fail e.style['scale'] = "-100% -100% 1" should set the property value
Pass e.style['scale'] = "-100 -100 1" should set the property value
Pass e.style['scale'] = "-100% -100% 1" should set the property value
Pass e.style['scale'] = "100 200" should set the property value
Pass e.style['scale'] = "100% 200%" should set the property value
Fail e.style['scale'] = "100 200 1" should set the property value
Fail e.style['scale'] = "100% 200% 1" should set the property value
Pass e.style['scale'] = "100 200 1" should set the property value
Pass e.style['scale'] = "100% 200% 1" should set the property value
Pass e.style['scale'] = "100 200 300" should set the property value
Pass e.style['scale'] = "100 100 2" should set the property value
Pass e.style['scale'] = "100% 200% 300%" should set the property value