mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-28 11:49:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Remove setting the Skia backend context in Navigable
Some checks are pending
CI / macOS, arm64, Sanitizer, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Fuzzers, Clang (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer, GNU (push) Waiting to run
Details
CI / Linux, x86_64, Sanitizer, Clang (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / macOS, arm64 (push) Waiting to run
Details
Package the js repl as a binary artifact / Linux, x86_64 (push) Waiting to run
Details
Run test262 and test-wasm / run_and_update_results (push) Waiting to run
Details
Lint Code / lint (push) Waiting to run
Details
Label PRs with merge conflicts / auto-labeler (push) Waiting to run
Details
Push notes / build (push) Waiting to run
Details

Browse source 
This is unused. The backend context is also referenced in the Skia
player, which we move to the rendering thread.
This commit is contained in:
Jelle Raaijmakers 2025-07-10 13:48:22 +02:00 • committed by Alexander Kalenik
commit d822b96786
Notes: github-actions[bot] 2025-07-10 13:29:06 +00:00
2 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibWeb/HTML/Navigable.cpp
View file

@ -150,7 +150,6 @@ Navigable::Navigable(GC::Ref<Page> page, bool is_svg_page)
}
m_rendering_thread.set_skia_player(move(skia_player));
m_rendering_thread.set_skia_backend_context(m_skia_backend_context);
m_rendering_thread.start(display_list_player_type);
}
}

2
Libraries/LibWeb/HTML/RenderingThread.h
View file

@ -28,7 +28,6 @@ public:
void start(DisplayListPlayerType);
void set_skia_player(OwnPtr<Painting::DisplayListPlayerSkia>&& player) { m_skia_player = move(player); }
void set_skia_backend_context(RefPtr<Gfx::SkiaBackendContext> context) { m_skia_backend_context = move(context); }
void enqueue_rendering_task(NonnullRefPtr<Painting::DisplayList>, Painting::ScrollStateSnapshot&&, NonnullRefPtr<Gfx::PaintingSurface>, Function<void()>&& callback);
private:
@ -38,7 +37,6 @@ private:
DisplayListPlayerType m_display_list_player_type;
OwnPtr<Painting::DisplayListPlayerSkia> m_skia_player;
RefPtr<Gfx::SkiaBackendContext> m_skia_backend_context;
RefPtr<Threading::Thread> m_thread;
Atomic<bool> m_exit { false };