mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-04-26 06:18:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Use Fetch to retrieve HTMLObjectElement data URLs

Browse source 
This eliminates the use of ResourceLoader in HTMLObjectElement. The spec
steps around fetching have been slightly updated since we've last looked
at this, so those are updated here.

Regarding the text test change: we cannot rely on the data: URL being
fetched synchronously. It will occur on a deferred task now. This does
match the behavior of other browsers, as they also will not have run the
fallback representation steps as of DOMContentLoaded.
This commit is contained in:
Timothy Flynn 2024-12-07 08:49:29 -05:00 • committed by Tim Flynn
parent fe891727dc
commit d835a00bee
Notes: github-actions[bot] 2024-12-10 18:37:56 +00:00
3 changed files with 216 additions and 136 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Libraries/LibWeb/HTML/HTMLObjectElement.h
View file

@ -12,14 +12,12 @@
#include <LibWeb/HTML/HTMLElement.h>
#include <LibWeb/HTML/NavigableContainer.h>
#include <LibWeb/Layout/ImageProvider.h>
#include <LibWeb/Loader/Resource.h>
namespace Web::HTML {
class HTMLObjectElement final
: public NavigableContainer
, public FormAssociatedElement
, public ResourceClient
, public Layout::ImageProvider {
WEB_PLATFORM_OBJECT(HTMLObjectElement, NavigableContainer)
GC_DECLARE_ALLOCATOR(HTMLObjectElement);
@ -28,7 +26,7 @@ class HTMLObjectElement final
enum class Representation {
Unknown,
Image,
NestedBrowsingContext,
ContentNavigable,
Children,
};
@ -64,16 +62,15 @@ private:
bool has_ancestor_media_element_or_object_element_not_showing_fallback_content() const;
void queue_element_task_to_run_object_representation_steps();
void run_object_representation_handler_steps(Optional<ByteString> resource_type);
void run_object_representation_handler_steps(Fetch::Infrastructure::Response const&, MimeSniff::MimeType const&, ReadonlyBytes);
void run_object_representation_completed_steps(Representation);
void run_object_representation_fallback_steps();
void load_image();
void update_layout_and_child_objects(Representation);
// ^ResourceClient
virtual void resource_did_load() override;
virtual void resource_did_fail() override;
void resource_did_load(Fetch::Infrastructure::Response const&, ReadonlyBytes);
void resource_did_fail();
// ^DOM::Element
virtual i32 default_tab_index_value() const override;
@ -87,13 +84,12 @@ private:
virtual void set_visible_in_viewport(bool) override;
virtual GC::Ref<DOM::Element const> to_html_element() const override { return *this; }
Representation m_representation { Representation::Unknown };
GC::Ptr<DecodedImageData> image_data() const;
Representation m_representation { Representation::Unknown };
GC::Ptr<SharedResourceRequest> m_resource_request;
public:
Optional<DOM::DocumentLoadEventDelayer> m_document_load_event_delayer_for_object_representation_task;
Optional<DOM::DocumentLoadEventDelayer> m_document_load_event_delayer_for_resource_load;
};