mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-07 00:29:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Report exceptions that occur during mutation observer microtask

Browse source
This commit is contained in:
Tim Ledbetter 2024-12-05 09:43:27 +00:00 • committed by Tim Ledbetter
commit d8511e39c9
Notes: github-actions[bot] 2024-12-19 15:26:36 +00:00
3 changed files with 40 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/Bindings/MainThreadVM.cpp
View file

@ -736,7 +736,7 @@ void queue_mutation_observer_microtask(DOM::Document const& document)
} }
} }
// 4. If records is not empty, then invoke mo’s callback with « records, mo », and mo. If this throws an exception, catch it, and report the exception. // 4. If records is not empty, then invoke mo’s callback with « records, mo » and "report", and with callback this value mo.
if (!records.is_empty()) { if (!records.is_empty()) {
auto& callback = mutation_observer->callback(); auto& callback = mutation_observer->callback();
auto& realm = callback.callback_context; auto& realm = callback.callback_context;
@ -748,9 +748,7 @@ void queue_mutation_observer_microtask(DOM::Document const& document)
MUST(wrapped_records->create_data_property(property_index, record.ptr())); MUST(wrapped_records->create_data_property(property_index, record.ptr()));
} }
auto result = WebIDL::invoke_callback(callback, mutation_observer, wrapped_records, mutation_observer); (void)WebIDL::invoke_callback(callback, mutation_observer, WebIDL::ExceptionBehavior::Report, wrapped_records, mutation_observer);
if (result.is_abrupt())
HTML::report_exception(result, realm);
} }
} }

6
Tests/LibWeb/Text/expected/wpt-import/dom/nodes/MutationObserver-cross-realm-callback-report-exception.txt Normal file
View file

@ -0,0 +1,6 @@
Harness status: OK
Found 1 tests
1 Pass
Pass MutationObserver reports the exception from its callback in the callback's global object

32
Tests/LibWeb/Text/input/wpt-import/dom/nodes/MutationObserver-cross-realm-callback-report-exception.html Normal file
View file

@ -0,0 +1,32 @@
<!doctype html>
<meta charset=utf-8>
<title>MutationObserver reports the exception from its callback in the callback's global object</title>
<script src=../../resources/testharness.js></script>
<script src=../../resources/testharnessreport.js></script>
<iframe></iframe>
<iframe></iframe>
<iframe></iframe>
<script>
setup({ allow_uncaught_exception: true });
const onerrorCalls = [];
window.onerror = () => { onerrorCalls.push("top"); };
frames[0].onerror = () => { onerrorCalls.push("frame0"); };
frames[1].onerror = () => { onerrorCalls.push("frame1"); };
frames[2].onerror = () => { onerrorCalls.push("frame2"); };
async_test(t => {
window.onload = t.step_func(() => {
const target = frames[0].document.body;
const mo = new frames[0].MutationObserver(new frames[1].Function(`throw new parent.frames[2].Error("PASS");`));
mo.observe(target, { childList: true, subtree: true });
target.append("foo");
t.step_timeout(() => {
assert_array_equals(onerrorCalls, ["frame1"]);
t.done();
}, 4);
});
});
</script>