mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-19 15:32:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Don't neglect DOM range updates on CharacterData changes

Browse source 
Regressed in 036327332f.

This commit moves the optimization a little later in replaceData(),
still avoiding relayout (the important part).

Recovers 480 points on WPT. :^)
This commit is contained in:
Andreas Kling 2025-02-21 11:05:59 +01:00 • committed by Andreas Kling
parent 4396dbb88e
commit d8f95c5050
Notes: github-actions[bot] 2025-02-21 10:54:57 +00:00
4 changed files with 3757 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Libraries/LibWeb/DOM/CharacterData.cpp
View file

@ -96,12 +96,12 @@ WebIDL::ExceptionOr<void> CharacterData::replace_data(size_t offset, size_t coun
full_data.append(after_data.data(), after_data.length_in_code_units());
Utf16View full_view { full_data };
// OPTIMIZATION: Skip subsequent steps if the data didn't change.
if (utf16_view == full_view) {
return {};
}
bool characters_are_the_same = utf16_view == full_view;
m_data = MUST(full_view.to_utf8(Utf16View::AllowInvalidCodeUnits::Yes));
// OPTIMIZATION: Skip UTF-8 encoding if the characters are the same.
if (!characters_are_the_same) {
m_data = MUST(full_view.to_utf8(Utf16View::AllowInvalidCodeUnits::Yes));
}
// 8. For each live range whose start node is node and start offset is greater than offset but less than or equal to offset plus count, set its start offset to offset.
for (auto& range : Range::live_ranges()) {
@ -134,6 +134,10 @@ WebIDL::ExceptionOr<void> CharacterData::replace_data(size_t offset, size_t coun
if (parent())
parent()->children_changed(nullptr);
// OPTIMIZATION: If the characters are the same, we can skip the remainder of this function.
if (characters_are_the_same)
return {};
// NOTE: Since the text node's data has changed, we need to invalidate the text for rendering.
// This ensures that the new text is reflected in layout, even if we don't end up
// doing a full layout tree rebuild.