From d9113e45f0e53ced9ec8e2381bc254884fa72a68 Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Thu, 15 May 2025 17:24:30 +0100 Subject: [PATCH] LibWeb/CSS: Discard trailing whitespace inside attribute selectors This gets us 84 more subtests, so everything in this syntax test passes. --- .../LibWeb/CSS/Parser/SelectorParsing.cpp | 2 ++ .../attribute-case/syntax.txt | Bin 23785 -> 23777 bytes 2 files changed, 2 insertions(+) diff --git a/Libraries/LibWeb/CSS/Parser/SelectorParsing.cpp b/Libraries/LibWeb/CSS/Parser/SelectorParsing.cpp index fcbbe94db00..d067116ae1e 100644 --- a/Libraries/LibWeb/CSS/Parser/SelectorParsing.cpp +++ b/Libraries/LibWeb/CSS/Parser/SelectorParsing.cpp @@ -383,6 +383,8 @@ Parser::ParseErrorOr Parser::parse_attribute_simple_se } } + attribute_tokens.discard_whitespace(); + if (attribute_tokens.has_next_token()) { dbgln_if(CSS_PARSER_DEBUG, "Was not expecting anything else inside attribute selector."); return ParseError::SyntaxError; diff --git a/Tests/LibWeb/Text/expected/wpt-import/css/selectors/attribute-selectors/attribute-case/syntax.txt b/Tests/LibWeb/Text/expected/wpt-import/css/selectors/attribute-selectors/attribute-case/syntax.txt index fb29f981c3c065afb091d4a2b1fa1c39f34ba75d..e18ea910a08a310397a920c3fd9e97d56b5b8425 100644 GIT binary patch delta 1070 zcmaF4lkwqB#tEt%rbZSD0g1)MlLM6uCUdayPyWEhy|I1~)8r3q{F4os#lZ9p7pchw zQi_v}m_;TxND57!uPQOQKuUhHzbp6TAIv^ru{bsM$+0X#P`2#k0x7x4dst+_`uDJK zPnL5Nn_M6zIa!G{6fD-pssN?=Cikg>7J4Fc?w&+4*IHfQFC^I3ePCQsm&oIHVxWAYguQK&e_WN$r) zcmOZ|3jCQmb$o(v1{2WqKc@itb$$ub5! zP&O#QmB4IJfL~CDh`&}h0E=m9$bxB5U>jJU5 z2Wmo-jJPMO>j{H}K>_Zg*8yjP0`#38KN4RH%7z4Jv5x#?9X>^fF)WkM>2puss_zC@ za+VL`Y>@2}xY#EDDVBqrZ*k((4IG&wO$a`IeNsmTr@B9r}H9YI2%6rCI8BezHS| z@Z>!#e3RT*CTE55L&G#Xh;t#|b7o znNOc{@?$@V$$a|q5NSw28u+q<4btILoa8Mud7VDjv49wpWtkNr3`14b$qB6d5Ka}d z5`?jUc@Bi(z@iRgh)!-`Q3Z1*xrt5Q&msh6>r75ym7MIr$~9Sq)f+4}*->3)azD(_ zg>L!?8`h}HOk#uD_6J!alua9=H{4x+a)P-0nvgyFyf3T!c$1Sq^`szEHB6yF+Cin+QP+SA55){e;YBHPqG}NIXyi*tI$`9UZlT>&# zK*@wNIw`TrR=u#av_f5>SRqy+Gf$zgG_xqXSRpq*C6x=LX7XJg^~neHWGDOca!f8Y zmYBRifMc>hFTz(B^dPBbasw|YN}%xwiVlB$sK+7EAvXDdp4j9#KEBBt^qnC-+sP+8 zIaVF2>Ls56+;^ZDsxyED$>fO!HW1|(4K!g4P|Sb~l$|Uuz&<(MNObZ70nW_@hUUU@ zAXjrnr{(9{swX8Dsb@m`72)dx@ee3RTySHNM^mPNt_~EN7uM{tU{JI!GQ9o1EawxA}sfARho!Lx?v3